Merge into development-branch : bump-server-abi-for-0.18 : Code : Mir

Status:	Merged
Approved by:	Cemil Azizoglu on 2015-11-19
Approved revision:	no longer in the source branch.
Merged at revision:	3107
Proposed branch:	lp://qastaging/~afrantzis/mir/bump-server-abi-for-0.18
Merge into:	lp://qastaging/mir
Diff against target:	538 lines (+112/-59) 4 files modified debian/control (+2/-2) debian/libmirserver36.install (+1/-1) src/server/CMakeLists.txt (+1/-1) src/server/symbols.map (+108/-55)
To merge this branch:	bzr merge lp://qastaging/~afrantzis/mir/bump-server-abi-for-0.18
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2015-11-19
Alan Griffiths			Approve on 2015-11-12
Andreas Pokorny (community)			Approve on 2015-11-09
Alberto Aguirre (community)		2015-10-29	Approve on 2015-11-04
Review via email: mp+276121@code.qastaging.launchpad.net

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-29:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5440/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Alberto Aguirre (albaguirre) wrote on 2015-11-04:

#

OK.

review: Approve

Revision history for this message

Andreas Pokorny (andreas-pokorny) wrote on 2015-11-05:

#

lgtm

amazing how much of .35 works with existing binaries (but then breaks in awkward situations)

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-05:

#

review: Needs Fixing (continuous-integration)

Revision history for this message

Andreas Pokorny (andreas-pokorny) wrote on 2015-11-05:

#

Something new:

running suite mir_performance_tests
+ date --utc --iso-8601=seconds
+ xargs echo '[timestamp] Start :' mir_performance_tests
[timestamp] Start : mir_performance_tests 2015-11-05T20:06:11+0000
+ grep -q mir_demo_client_
+ grep -q mir_privileged_tests
+ phablet-test-run -x -s JB044235 -v umockdev-run -- mir_performance_tests
running umockdev-run -- mir_performance_tests
initctl: unable to determine sessions
initctl: unable to determine sessions
Running main() from main.cpp
[0;32m[==========] [mRunning 1 test from 1 test case.
[0;32m[----------] [mGlobal test environment set-up.
[0;32m[----------] [m1 test from GLMark2Test
[0;32m[ RUN ] [mGLMark2Test.benchmark_fullscreen_default
[1446753971.301882] mirplatform: Found graphics driver: android
[1446753971.302670] mirplatform: Found graphics driver: mesa-kms
[1446753971.302822] mirplatform: Found graphics driver: mesa-x11
[1446753971.303433] mirplatform: Found graphics driver: dummy
ERROR: Throw location unknown (consider using BOOST_THROW_EXCEPTION)
Dynamic exception type: N5boost16exception_detail10clone_implINS0_19error_info_injectorINS_6system12system_errorEEEEE
std::exception::what: bind: No such file or directory

unknown file: Failure
C++ exception with description "Failed to start server thread" thrown in SetUp().
[0;31m[ FAILED ] [mGLMark2Test.benchmark_fullscreen_default (10044 ms)
[0;32m[----------] [m1 test from GLMark2Test (10044 ms total)

[0;32m[----------] [mGlobal test environment tear-down
[0;32m[==========] [m1 test from 1 test case ran. (10045 ms total)
[0;32m[ PASSED ] [m0 tests.
[0;31m[ FAILED ] [m1 test, listed below:
[0;31m[ FAILED ] [mGLMark2Test.benchmark_fullscreen_default

1 FAILED TEST

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-06:

#

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-06:

#

review: Needs Fixing (continuous-integration)

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2015-11-06:

#

An unusual end to mir_acceptance_tests...

6: [ RUN ] SurfaceModifications.surface_spec_with_fixed_aspect_ratio_and_size_range_is_respected
6: [1446779168.989645] mirserver: Starting
6: [1446779168.989767] mirserver: Selected driver: dummy (version 0.18.0)
6: [1446779168.992141] mirserver: Initial display configuration:
6: [1446779168.992159] mirserver: 1.1: VGA 0.0" 0x0mm
6: [1446779168.992165] mirserver: Current mode 1600x1600 60.00Hz
6: [1446779168.992169] mirserver: Preferred mode 1600x1600 60.00Hz
6: [1446779168.992172] mirserver: Logical position +0+0
6: [1446779168.993376] mirserver: Mir version 0.18.0
6: /mir/tools/detect_fd_leaks.bash: line 84: 5874 Hangup $@ 2>&1
6: 5875 Done | detect_fd_leaks
6/14 Test #6: mir_acceptance_tests ..............***Failed 23.08 sec

...but I don't see how it relates to these changes.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-06:

#

review: Needs Fixing (continuous-integration)

Revision history for this message

Andreas Pokorny (andreas-pokorny) on 2015-11-09:

#

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-09:

#

review: Needs Fixing (continuous-integration)

Revision history for this message

Andreas Pokorny (andreas-pokorny) wrote on 2015-11-09:

#

[----------] tests from AndroidHardwareSanity
[1447060975.014825] mircommon: Loading modules from: /usr/lib/arm-linux-gnueabihf/mir/server-platform
[1447060975.015270] mircommon: Loading module: /usr/lib/arm-linux-gnueabihf/mir/server-platform/graphics-android.so.7
[1447060975.015403] mircommon: Loading module: /usr/lib/arm-linux-gnueabihf/mir/server-platform/graphics-mesa-kms.so.7
[1447060975.021150] mircommon: Loading module: /usr/lib/arm-linux-gnueabihf/mir/server-platform/server-mesa-x11.so.7
[1447060975.026289] mircommon: Loading module: /usr/lib/arm-linux-gnueabihf/mir/server-platform/graphics-android.so.6
[1447060975.028245] mircommon: Loading module: /usr/lib/arm-linux-gnueabihf/mir/server-platform/input-evdev.so.4
[1447060975.032376] mircommon: Loading module: /usr/lib/arm-linux-gnueabihf/mir/server-platform/graphics-dummy.so
[1447060975.032542] mircommon: Loading module: /usr/lib/arm-linux-gnueabihf/mir/server-platform/input-stub.so
[1447060975.033007] mirplatform: Found graphics driver: android
[1447060975.033471] mirplatform: Found graphics driver: mesa-kms
[1447060975.033596] mirplatform: Found graphics driver: mesa-x11
[1447060975.033860] mirplatform: Found graphics driver: dummy
[1447060975.034946] mirserver: Selected driver: android (version 0.18.0)
[1447060975.072959] mirserver: Initial display configuration:
[1447060975.073471] mirserver: 0.0: LVDS 4.6" 57x101mm
[1447060975.073577] mirserver: Current mode 540x960 66.57Hz
[1447060975.073642] mirserver: Preferred mode 540x960 66.57Hz
[1447060975.073700] mirserver: Logical position +0+0
[1447060975.073816] mirserver: 0.1: unused DisplayPort
[1447060975.078786] mirserver: Mir version 0.18.0
[ RUN ] [mAndroidHardwareSanity.client_can_draw_with_cpu
[ OK ] [mAndroidHardwareSanity.client_can_draw_with_cpu (30 ms)
[ RUN ] [mAndroidHardwareSanity.client_can_draw_with_gpu
[ OK ] [mAndroidHardwareSanity.client_can_draw_with_gpu (30 ms)
[ RUN ] [mAndroidHardwareSanity.display_can_post
[ OK ] [mAndroidHardwareSanity.display_can_post (6 ms)
[ RUN ] [mAndroidHardwareSanity.display_can_post_overlay
[ OK ] [mAndroidHardwareSanity.display_can_post_overlay (2 ms)
[ RUN ] [mAndroidHardwareSanity.can_allocate_sw_buffer
[ OK ] [mAndroidHardwareSanity.can_allocate_sw_buffer (3 ms)
[ RUN ] [mAndroidHardwareSanity.can_allocate_hw_buffer
[ OK ] [mAndroidHardwareSanity.can_allocate_hw_buffer (10 ms)
/bin/bash: line 1: 2385 Segmentation fault (core dumped) umockdev-run -- mir_integration_tests
+ mir_rc=-1
+ date --utc --iso-8601=seconds

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2015-11-12:

#

Yes

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-12:

#

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) on 2015-11-19:

#

review: Approve (continuous-integration)

Mir

Merge lp://qastaging/~afrantzis/mir/bump-server-abi-for-0.18 into lp://qastaging/mir

Commit message

Description of the change

Preview Diff

Subscribers