Merge lp://qastaging/~afrantzis/mir/clock-steady-duration-for-timestamp into lp://qastaging/mir
Status: | Rejected |
---|---|
Rejected by: | Alexandros Frantzis |
Proposed branch: | lp://qastaging/~afrantzis/mir/clock-steady-duration-for-timestamp |
Merge into: | lp://qastaging/mir |
Prerequisite: | lp://qastaging/~afrantzis/mir/clock-rework |
Diff against target: |
247 lines (+26/-26) 13 files modified
common-ABI-sha1sums (+1/-1) include/common/mir/time/types.h (+2/-2) server-ABI-sha1sums (+1/-1) src/client/logging/perf_report.cpp (+2/-2) src/common/symbols.map (+1/-1) src/common/time/CMakeLists.txt (+1/-1) src/common/time/steady_clock.cpp (+4/-4) src/include/common/mir/time/steady_clock.h (+5/-5) src/server/default_server_configuration.cpp (+2/-2) tests/include/mir_test_doubles/advanceable_clock.h (+2/-2) tests/mir_test_doubles/mock_timer.cpp (+1/-1) tests/unit-tests/graphics/mesa/test_display.cpp (+2/-2) tests/unit-tests/test_asio_main_loop.cpp (+2/-2) |
To merge this branch: | bzr merge lp://qastaging/~afrantzis/mir/clock-steady-duration-for-timestamp |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alan Griffiths | Needs Information | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Review via email:
|
Commit message
time: Use a steady (monotonic) clock
We use mir::time::Clock to calculate intervals, which is dangerous if we use a non-monotonic clock (std::chrono:
A problem with our current approach is that the clock type leaks into our public interface (through the mir::time:
Description of the change
time: Use a steady (monotonic) clock
We use mir::time::Clock to calculate intervals, which is dangerous if we use a non-monotonic clock (std::chrono:
A problem with our current approach is that the clock type leaks into our public interface (through the mir::time:
Also see the alternative proposal that introduces the steady clock without the fix for the clock type leak: https:/
Unmerged revisions
- 2021. By Alexandros Frantzis
-
time: Use a steady (monotonic) clock and make the timestamp clock-independent
FAILED: Continuous integration, rev:2021 jenkins. qa.ubuntu. com/job/ mir-ci/ 1978/ jenkins. qa.ubuntu. com/job/ mir-android- utopic- i386-build/ 2343 jenkins. qa.ubuntu. com/job/ mir-clang- utopic- amd64-build/ 2353/console jenkins. qa.ubuntu. com/job/ mir-mediumtests -utopic- touch/2278/ console jenkins. qa.ubuntu. com/job/ mir-utopic- amd64-ci/ 323/console jenkins. qa.ubuntu. com/job/ mir-mediumtests -builder- utopic- armhf/1215/ console
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/mir- ci/1978/ rebuild
http://