Mir

Merge lp://qastaging/~afrantzis/mir/fix-1466492-map-minimized-to-hidden into lp://qastaging/mir

  1. fix-1466492-map-minimized-to-hidden
  2. Merge into development-branch
Proposed by Alexandros Frantzis
Status: Rejected
Rejected by: Alexandros Frantzis
Proposed branch: lp://qastaging/~afrantzis/mir/fix-1466492-map-minimized-to-hidden
Merge into: lp://qastaging/mir
Diff against target: 37 lines (+19/-0)
2 files modified
src/server/shell/canonical_window_manager.cpp (+2/-0)
tests/acceptance-tests/test_surface_modifications.cpp (+17/-0)
To merge this branch: bzr merge lp://qastaging/~afrantzis/mir/fix-1466492-map-minimized-to-hidden
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Alberto Aguirre (community) Disapprove
Review via email: mp+262450@code.qastaging.launchpad.net

Commit message

shell: Ensure mir_surface_state_minimized is always mapped to mir_surface_state_hidden by the CanonicalWindowManagerPolicy

Description of the change

shell: Ensure mir_surface_state_minimized is always mapped to mir_surface_state_hidden by the CanonicalWindowManagerPolicy

To post a comment you must log in.
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

I'd rather avoid mapping the state at all - this was a workaround I put it initially - but proposed fix here: https://code.launchpad.net/~albaguirre/mir/no-minimize-to-hidden-mapping/+merge/262465

review: Disapprove
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:2688
http://jenkins.qa.ubuntu.com/job/mir-ci/4153/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/2932
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-wily-amd64-build/447
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/2880/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/309
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/309/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/2880
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/2880/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/5704/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/21325

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/4153/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

2688. By Alexandros Frantzis

shell: Ensure mir_surface_state_minimized is always mapped to mir_surface_state_hidden by the CanonicalWindowManagerPolicy

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches