Mir

Merge lp://qastaging/~afrantzis/mir/fix-1517781-double-close into lp://qastaging/mir

fix-1517781-double-close
Merge into development-branch

Proposed by Alexandros Frantzis on 2015-11-19

Status:

Merged

Approved by:

Alberto Aguirre on 2015-11-19

Approved revision:

no longer in the source branch.

Merged at revision:

3111

Proposed branch:

lp://qastaging/~afrantzis/mir/fix-1517781-double-close

Merge into:

lp://qastaging/mir

Diff against target:

49 lines (+6/-7)

2 files modified

include/test/mir_test_framework/async_server_runner.h (+1/-3)
tests/mir_test_framework/async_server_runner.cpp (+5/-4)

To merge this branch:

bzr merge lp://qastaging/~afrantzis/mir/fix-1517781-double-close

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2015-11-19
Alberto Aguirre (community)			Approve on 2015-11-19
Alan Griffiths		2015-11-19	Approve on 2015-11-19
Review via email: mp+278032@code.qastaging.launchpad.net

Commit message

tests: Avoid double-closing the mir connection fd

Description of the change

tests: Avoid double-closing the mir connection fd

Besides being obviously wrong, it can lead to very mysterious failures in completely unrelated parts of the code (see bug 1517781).

I wonder if this is the cause of any other mysterious failures we have seen.

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2015-11-19:

Makes sense.

But I can still reproduce problems in e.g. NestedServer.display_configuration_reset_when_application_exits

Vis:

Repeating all tests (iteration 429) . . .

Note: Google Test filter = NestedServer.display_configuration_reset_when_application_exits
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from NestedServer
[ RUN ] NestedServer.display_configuration_reset_when_application_exits
/home/alan/display_server/mir3/tests/acceptance-tests/test_nested_mir.cpp:755: Failure
Value of: condition.woken()
Actual: false
Expected: true
Segmentation fault (core dumped)