tests: Replace racy wait function in DefaultInputManagerTests with timeouts
The wait_for_multiplexer_dispatch() function injects an action into the platform action queue, assuming that when it finishes all actions related to the DefaultInputManager that have been scheduled previously will have finished.
However, DefaultInputManager uses an additional internal action queue for some actions. This action queue is multiplexed with the platform action queue in a way that doesn't provide any guarantees about the order of actions from different queues.
In the "forwards_pause_continue_state_changes_to_platform" test the pause_for_config / continue_after_config actions and the wait_for_multiplexer_dispatch action are scheduled effectively concurrently in the internal and platform queues, respectively. It often happens that the platform queue is serviced first and thus the test ends before the pause/continue actions are performed.
This MP removes the racy wait_for_multiplexer_dispatch() function and updates the tests that use it as follows:
* In "forwards_pause_continue_state_changes_to_platform" wait_for_multiplexer_dispatch() is replaced with an mt::Signal triggered by the pause/continue actions.
* The "starts_platforms_after_start" test is removed completely as it doesn't test anything more or different from the "starts_platforms_on_start" test.
* In "ignore_spurious_starts" we just remove the call to wait_for_multiplexer_dispatch(), since no kind of additional synchronization point is needed for the test to function properly.
FAILED: Continuous integration, rev:4059
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/