Mir

Merge lp://qastaging/~afrantzis/mir/plug-ThreadedDispatcherTest-fd-leaks into lp://qastaging/mir

  1. plug-ThreadedDispatcherTest-fd-leaks
  2. Merge into development-branch
Proposed by Alexandros Frantzis
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 2601
Proposed branch: lp://qastaging/~afrantzis/mir/plug-ThreadedDispatcherTest-fd-leaks
Merge into: lp://qastaging/mir
Diff against target: 58 lines (+25/-16)
1 file modified
tests/unit-tests/dispatch/test_threaded_dispatcher.cpp (+25/-16)
To merge this branch: bzr merge lp://qastaging/~afrantzis/mir/plug-ThreadedDispatcherTest-fd-leaks
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alan Griffiths Approve
Kevin DuBois (community) Approve
Chris Halse Rogers Approve
Robert Carr (community) Approve
Review via email: mp+259975@code.qastaging.launchpad.net

Commit message

tests: Plug ThreadedDispatcherTest fd leaks

Description of the change

tests: Plug ThreadedDispatcherTest fd leaks

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:2599
http://jenkins.qa.ubuntu.com/job/mir-ci/3894/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/2572
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-wily-amd64-build/83
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/2520
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/50
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/50/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/2520
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/2520/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/5390
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20724

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/3894/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Nit: While it is clear enough to us now I think the unusual approach of explicitly deleting an stack object probably deserves a comment for the next person to maintain this code. (Even sticking it in a pointer so that it can be reset could be distracting.)

review: Needs Fixing
Revision history for this message
Robert Carr (robertcarr) wrote :

Same thought as GLibMainLoop branch :)

review: Approve
Revision history for this message
Chris Halse Rogers (raof) wrote :

+1 to Alan's needs fixing. Otherwise OK.

review: Approve
Revision history for this message
Kevin DuBois (kdub) :
review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Good enough

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:2600
http://jenkins.qa.ubuntu.com/job/mir-ci/3935/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/2616
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-wily-amd64-build/127
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/2564/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/91
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/91/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/2564
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/2564/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/5415/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20813

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/3935/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches