Mir

Merge lp://qastaging/~afrantzis/mir/unique-module-ptr-event-handlers into lp://qastaging/mir

  1. unique-module-ptr-event-handlers
  2. Merge into development-branch
Proposed by Alexandros Frantzis
Status: Merged
Approved by: Alexandros Frantzis
Approved revision: no longer in the source branch.
Merged at revision: 3153
Proposed branch: lp://qastaging/~afrantzis/mir/unique-module-ptr-event-handlers
Merge into: lp://qastaging/mir
Diff against target: 509 lines (+240/-72)
11 files modified
include/platform/mir/graphics/event_handler_register.h (+10/-0)
src/include/server/mir/glib_main_loop.h (+9/-0)
src/platforms/android/server/display.cpp (+7/-4)
src/platforms/mesa/server/kms/display.cpp (+9/-8)
src/platforms/mesa/server/kms/linux_virtual_terminal.cpp (+25/-24)
src/server/glib_main_loop.cpp (+34/-0)
tests/include/mir/test/doubles/mock_event_handler_register.h (+71/-0)
tests/include/mir/test/doubles/mock_main_loop.h (+22/-0)
tests/unit-tests/graphics/mesa/kms/test_display.cpp (+3/-17)
tests/unit-tests/graphics/mesa/kms/test_linux_virtual_terminal.cpp (+4/-19)
tests/unit-tests/test_glib_main_loop.cpp (+46/-0)
To merge this branch: bzr merge lp://qastaging/~afrantzis/mir/unique-module-ptr-event-handlers
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alberto Aguirre (community) Approve
Review via email: mp+279017@code.qastaging.launchpad.net

Commit message

platform: Ensure the platform library is not unloaded while the event handlers it registered are alive

Description of the change

platform: Ensure the platform library is not unloaded while the event handlers it registered are alive

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3148
http://jenkins.qa.ubuntu.com/job/mir-ci/5724/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5112
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4018
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5060
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-xenial-touch/58/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/53
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/53/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/53
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/53/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5060
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5060/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7594
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25645
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/56/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5724/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

Looks good.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-autolanding/2197/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5123
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4029
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5071
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-autolanding/31/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-autolanding/31
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-autolanding/31/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5071
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5071/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7604
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25661

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches