Mir

Merge lp://qastaging/~afrantzis/mir/workaround-valgrind-with-glibc-2.21 into lp://qastaging/mir

Proposed by Alexandros Frantzis
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 2420
Proposed branch: lp://qastaging/~afrantzis/mir/workaround-valgrind-with-glibc-2.21
Merge into: lp://qastaging/mir
Diff against target: 1492 lines (+1436/-3)
4 files modified
cmake/MirCommon.cmake (+2/-0)
tests/unit-tests/test_fatal.cpp (+3/-3)
tools/valgrind_suppressions_armhf (+27/-0)
tools/valgrind_suppressions_glibc_2.21 (+1404/-0)
To merge this branch: bzr merge lp://qastaging/~afrantzis/mir/workaround-valgrind-with-glibc-2.21
Reviewer Review Type Date Requested Status
Alan Griffiths Approve
Kevin DuBois (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+253815@code.qastaging.launchpad.net

Commit message

tests: Temporarily provide own version of glibc 2.21 valgrind suppressions

Workaround for bug #1435261.

Description of the change

tests: Temporarily provide own version of glibc 2.21 valgrind suppressions

Workaround for bug #1435261.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

mir-android-vivid-amd64-build passed, which means this branch does indeed help.

The mir-android-vivid-i386-build failure is an infrastructure glitch.

I added __udivmoddi4 valgrind suppression, which should help with the armhf builds. Let's see...

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Kevin DuBois (kdub) wrote :

lgtm, thanks!

review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Expedient. But in a better world we wouldn't need most of this (we should revert if/when we can).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches