Unity System Compositor

Merge lp://qastaging/~afrantzis/unity-system-compositor/fix-1543495-spinner-orientation into lp://qastaging/unity-system-compositor

  1. fix-1543495-spinner-orientation
  2. Merge into trunk
Proposed by Alexandros Frantzis
Status: Merged
Approved by: Alexandros Frantzis
Approved revision: 275
Merged at revision: 276
Proposed branch: lp://qastaging/~afrantzis/unity-system-compositor/fix-1543495-spinner-orientation
Merge into: lp://qastaging/unity-system-compositor
Diff against target: 344 lines (+119/-122)
2 files modified
debian/control (+1/-0)
spinner/eglspinner.cpp (+118/-122)
To merge this branch: bzr merge lp://qastaging/~afrantzis/unity-system-compositor/fix-1543495-spinner-orientation
Reviewer Review Type Date Requested Status
Andreas Pokorny (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+285621@code.qastaging.launchpad.net

Commit message

Orient the spinner according to the native orientation of the device

Description of the change

Orient the spinner according to the native orientation of the device

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:275
http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ci/344/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-xenial-amd64-ci/45/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-xenial-armhf-ci/44/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-xenial-i386-ci/44/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-system-compositor-ci/344/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:275
http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ci/347/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-xenial-amd64-ci/48
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-xenial-armhf-ci/47
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-xenial-i386-ci/47

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-system-compositor-ci/347/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

I dont like the logic around HAVE_PROPS and then taking the device configuration file or android.conf. Sine we will do that on regular desktops too. But that is preexisting.

Additionally what if someone configures a value in android.conf or generic.conf but does not set that value in the per device configuration, again preexisting.

review: Approve
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

I agree that the logic there could be improved, especially for the desktop, but as you note it's all pre-existing so we are not breaking anything that's not already broken. Hopefully the refactoring that was performed will make it much easier to change the code in the future.

> Additionally what if someone configures a value in android.conf or generic.conf
> but does not set that value in the per device configuration, again preexisting.

The per device configurations are just a fallback in case no android.conf is found. Note that android.conf is not part of the regular ubuntu package that provides the conf files, but is provided by the android part of the system image and is therefore device specific (i.e., /etc/ubuntu-touch-session.d/android.conf is really mounted from /system/ubuntu/etc/ubuntu-touch-session.d/android.conf). All recent images provide a suitable android.conf.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches