Merge lp://qastaging/~afrantzis/unity-system-compositor/voice-call-proximity-over-0.1 into lp://qastaging/unity-system-compositor/ubuntu

PASSED: Continuous integration, rev:253
http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ubuntu-ci/18/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ubuntu-wily-amd64-ci/16
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ubuntu-wily-armhf-ci/16

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-system-compositor-ubuntu-ci/18/rebuild

so after testing, i get proximity blanking for the text messages.
but i do not get proximity blanking for the incoming voice call notification.
is that what i'm supposed to see ?
i'm on arale.

> so after testing, i get proximity blanking for the text messages.
> but i do not get proximity blanking for the incoming voice call notification.
> is that what i'm supposed to see ?
> i'm on arale.

No, you should also get proximity blanking for voice call notifications. This used to work, so I figured something must have changed outside USC/powerd.

After some investigation I found that the problem is the new notification handling logic in Unity8. With the new logic Unity8 sends a "turn screen on" message with reason "unknown" when a snap decision prompt is shown. This confuses USC because it has already got a "call" notification from powerd.

Once again our distributed and uncoordinated power-management logic is making our lives difficult and is a constant source of bugs and fragility.

I need to think a bit more about how to solve this particular problem. Stay tuned.

PASSED: Continuous integration, rev:254
http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ubuntu-ci/23/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ubuntu-wily-amd64-ci/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ubuntu-wily-armhf-ci/21

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-system-compositor-ubuntu-ci/23/rebuild

PASSED: Continuous integration, rev:255
http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ubuntu-ci/24/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ubuntu-wily-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ubuntu-wily-armhf-ci/22

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-system-compositor-ubuntu-ci/24/rebuild

retested with https://code.launchpad.net/~afrantzis/unity8/power-state-change-reason-snap-decision
it matched what i expected, I hammered on this pretty good.
I found only 2 cosmetic issues, and 1 issue that should likely be addressed (unless it's already a bug)

cosmetic issue 1: if a text or call occurs, screen is lit, no interaction it will dim. getting a call or text at that moment will not brighten the screen.

cosmetic issue 2: incoming call, cover and uncover proximity sensor quickly/rapidly and every now and then you will hear the audio stutter only very slightly

issue to fix: if you are on an active call and hit power button to blank screen, generate a second incoming call - as a user you have no idea this has occured, there is no vibra nor does the screen light. At least with a text the vibra will activate, but no lighting screen. The screen should probably light up in both these instances.

cosmetic issues mentioned above should not prevent landing

sorry for comments galore, i meant to also add if the last issue is already a bug, then I wouldn't consider it a blocker for landing this as this is a huge improvement.

> retested with https://code.launchpad.net/~afrantzis/unity8/power-state-change-
> reason-snap-decision
> it matched what i expected, I hammered on this pretty good.

Thanks for testing!

> I found only 2 cosmetic issues, and 1 issue that should likely be addressed
> (unless it's already a bug)

> cosmetic issue 1: if a text or call occurs, screen is lit, no interaction it
> will dim. getting a call or text at that moment will not brighten the screen.

From a quick look at the related USC code, this should be easily fixable (Famous last words? Let's see... :) )

> cosmetic issue 2: incoming call, cover and uncover proximity sensor
> quickly/rapidly and every now and then you will hear the audio stutter only
> very slightly

Covering/uncovering the proximity sensor is an intensive task that involves cross process communication and the teardown and setup of our input and graphics subsystems in USC/Mir. I can't really see anything simple (i.e. as a bugfix) we can do to improve this on the USC side.

> issue to fix: if you are on an active call and hit power button to blank
> screen, generate a second incoming call - as a user you have no idea this has
> occured, there is no vibra nor does the screen light. At least with a text the
> vibra will activate, but no lighting screen. The screen should probably light
> up in both these instances.

This is indeed a regression. With the new code, when a call arrives, USC enables proximity handling and expects a proximity event with the initial proximity state. This is done in order to avoid turning on the screen for a moment if the proximity is "near". However, if proximity handling is already enabled (in this case because the dialer-app has enabled it) USC won't receive a proximity event with the initial state and won't turn on the screen. I am confident there is a way to improve this within our current architecture, but it will probably involve more communication between powerd and USC and more state keeping. I will experiment with a few approaches.

Note that when a second call arrives the users get a beeping noise in the call audio output, so they do get some notification.

Stay tuned!

PASSED: Continuous integration, rev:257
http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ubuntu-ci/25/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ubuntu-wily-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ubuntu-wily-armhf-ci/23

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-system-compositor-ubuntu-ci/25/rebuild