Merge lp://qastaging/~afrantzis/unity8/notifications-powerd-off into lp://qastaging/unity8
| Status: | Merged |
|---|---|
| Approved by: | Lukáš Tinkl |
| Approved revision: | 2410 |
| Merged at revision: | 2470 |
| Proposed branch: | lp://qastaging/~afrantzis/unity8/notifications-powerd-off |
| Merge into: | lp://qastaging/unity8 |
| Diff against target: |
33 lines (+16/-0) 1 file modified
qml/Notifications/Notification.qml (+16/-0) |
| To merge this branch: | bzr merge lp://qastaging/~afrantzis/unity8/notifications-powerd-off |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Approve | |
| Lukáš Tinkl (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Improve the way notifications interact with power management
The improvements are:
1. PlaceHolder notifications are ignored.
2. Notifications send a Powerd.Off event on destruction, to notify
the power manager of their lifetime.
Description of the change
Improve the way notifications interact with power management
The improvements are:
1. PlaceHolder notifications are ignored.
2. Notifications send a Powerd.Off event on destruction, to notify
the power manager of their lifetime.
* Are there any related MPs required for this MP to build/function as expected? Please list.
No.
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable
* If you changed the UI, has there been a design review?
Not applicable
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
Thanks for the fixes!
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
* Did CI run pass? If not, please explain why.
Didn't run yet, no idea why; tests passing locally