unity-2d

Merge lp://qastaging/~agateau/unity-2d/edge-reveal into lp://qastaging/unity-2d/3.0

  1. edge-reveal
  2. Merge into natty
Proposed by Aurélien Gâteau
Status: Merged
Approved by: Ugo Riboni
Approved revision: 554
Merged at revision: 583
Proposed branch: lp://qastaging/~agateau/unity-2d/edge-reveal
Merge into: lp://qastaging/unity-2d/3.0
Diff against target: 318 lines (+168/-5)
7 files modified
launcher/app/CMakeLists.txt (+2/-0)
launcher/app/autohidebehavior.cpp (+26/-3)
launcher/app/autohidebehavior.h (+8/-0)
launcher/app/edgehitdetector.cpp (+57/-0)
launcher/app/edgehitdetector.h (+44/-0)
launcher/app/intellihidebehavior.cpp (+25/-2)
launcher/app/intellihidebehavior.h (+6/-0)
To merge this branch: bzr merge lp://qastaging/~agateau/unity-2d/edge-reveal
Reviewer Review Type Date Requested Status
Ugo Riboni (community) Approve
Florian Boucault (community) functional Needs Fixing
Review via email: mp+59362@code.qastaging.launchpad.net

Commit message

[launcher] In *Hide behaviors, show launcher when hitting left edge

Description of the change

This branch changes the way the launcher is shown in *Hide mode to match latest unity-3d behavior: hit the left edge of the screen to show the launcher.

It has been tested with multiple screens of different heights.

To post a comment you must log in.
Revision history for this message
Florian Boucault (fboucault) wrote :

16:46 < Kaleo> agateau: the edge reveal does not behave like in Unity 3D
16:47 < Kaleo> agateau: and provokes a lot of false positives
16:47 < Kaleo> agateau: where the user will reach for example for the back button in Firefox and accidentally reveal the launcher
16:48 < agateau> Kaleo: so what does unity-3d do?
16:48 < Kaleo> agateau: I don't know the exact technical details but it takes a little while for the launcher to show when I reach the edge
16:48 < Kaleo> agateau: the code needs to be looked at
16:48 < agateau> Kaleo: ok

review: Needs Fixing (functional)
lp://qastaging/~agateau/unity-2d/edge-reveal updated
552. By Aurélien Gâteau

Merged trunk

553. By Aurélien Gâteau

Cursor must stay on edge for 500ms to cause launcher to reveal

Same timeout as unity-3d

554. By Aurélien Gâteau

EdgeMouseArea no longer IsA MouseArea, so rename it

Revision history for this message
Florian Boucault (fboucault) wrote :

In the current form, merging this would add the bug Unity 3D has:
https://bugs.launchpad.net/ubuntu/+source/unity/+bug/757650

Revision history for this message
Aurélien Gâteau (agateau) wrote :

John Lea agreed it should not block the merge of edge-reveal in unity-2d:
"""
[14:50:29] <agateau> JohnLea: hey, it seems you are active here. Can I have your opinion regarding bug #757650 ?
[14:50:30] <_mup_> Bug #757650: Unable to select a maximised app by clicking on left edge of the screen <apport-bug> <compiz-0.9> <i386> <natty> <needs-design> <running-unity> <ubuntu> <Ayatana Design:New> <unity:Incomplete> <unity (Ubuntu):Incomplete> < https://launchpad.net/bugs/757650 >
[14:50:57] <agateau> JohnLea: whether it matters or not will decide edge-reveal can be merged into unity-2d
[15:00:14] <JohnLea_> agateau; that is a good bug, I'll accept is a UX bug that needs fixing
[15:03:04] <agateau> JohnLea_: triggering the bug requires quite sharp reflexes... and is going to be quite complicated to fix... (read: X is getting in the way here) :(
[15:03:35] <JohnLea_> agateau; it's not a high priority bug, but it is a valid bug
[15:03:55] <JohnLea_> agateau; I'm adding a bit of clarity to the bug description
[15:04:01] <agateau> JohnLea_: ok. Do you think it should block the landing of edge-reveal feature in unity-2d?
[15:05:44] <JohnLea_> agateau; no, definitely not. Edge reveal is very important, this is far less important. However it will become a little bit more important with the *new* more responsive edge reveal behaviour that is on Jason's todo list
"""

Revision history for this message
Ugo Riboni (uriboni) wrote :

Works as advertised and code looks good.
I also confirm that this introduces bug #757650 for us, as expected.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches