Merge lp://qastaging/~agilebg/account-consolidation/7.0-fix-1334645-elbati into lp://qastaging/~account-core-editors/account-consolidation/7.0

thanks for the fix Lorenzo.

Can you confirm that the test is correct and production code was actually broken?

I confirm.
Note that the bug only occurs when you create a new tax code without parent.

Hi Lorenzo,

I am still non convinced :)

This way the test is not actually testing a useful workflow, but just a "return True" workaround.

I'd be happier if the yaml test actually tested a realistic case. (or at least, clarify in the yaml file what's going on)

Thanks!

lep, right. I looked at it better and saw that if parent_id is missing, I should just not fill the parent_id field of the parallel account.

Thanks Lorenzo.

maybe you could refactor a bit putting

parent_parallel_tax_code_id = False

in an else: block a few lines down? otherwise, lgtm

On 07/07/2014 03:00 PM, Leonardo Pistone - camptocamp wrote:
> maybe you could refactor a bit putting
>
> parent_parallel_tax_code_id = False
>
> in an else: block a few lines down? otherwise, lgtm

Done

thanks

This project is now hosted on https://github.com/OCA/account-consolidation. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

Moved to https://github.com/OCA/account-consolidation/pull/3