Merge into 7.0-add_account_invoice_template : 7.0-add_account_invoice_template_fixes : Code : Account

Status:	Merged
Approved by:	bruno bottacini on 2013-10-31
Approved revision:	117
Merge reported by:	bruno bottacini
Merged at revision:	not available
Proposed branch:	lp://qastaging/~agilebg/account-financial-tools/7.0-add_account_invoice_template_fixes
Merge into:	lp://qastaging/~bruno-bottacini/account-financial-tools/7.0-add_account_invoice_template
Diff against target:	297 lines (+73/-57) 4 files modified account_invoice_template/__init__.py (+1/-1) account_invoice_template/__openerp__.py (+8/-5) account_invoice_template/account_invoice_template.py (+22/-15) account_invoice_template/wizard/select_template.py (+42/-36)
To merge this branch:	bzr merge lp://qastaging/~agilebg/account-financial-tools/7.0-add_account_invoice_template_fixes
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
bruno bottacini		2013-08-30	Approve on 2013-10-31
Nicolas Bessi - Camptocamp (community)	no test, code review		Approve on 2013-09-02
Review via email: mp+183205@code.qastaging.launchpad.net

Revision history for this message

Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote on 2013-09-02:

#

Hello,

Thanks for the patch.

The diff looks good to me.

That said the module needs a general cleanup and review.

There is some oddities here and there and
a simple pass of the wizard file on flake 8 gave the following output:

select_template.py:3:2:warning: W291 trailing whitespace (python-flake8)
select_template.py:22:31:error: E231 missing whitespace after ',' (python-flake8)
select_template.py:23:1:warning: F401 'time' imported but unused (python-flake8)
select_template.py:26:1:error: E302 expected 2 blank lines, found 1 (python-flake8)
select_template.py:30:101:error: E501 line too long (102 > 100 characters) (python-flake8)
select_template.py:33:33:error: E231 missing whitespace after ',' (python-flake8)
select_template.py:38:17:error: E222 multiple spaces after operator (python-flake8)
select_template.py:46:48:error: E231 missing whitespace after ',' (python-flake8)
select_template.py:58:101:error: E501 line too long (117 > 100 characters) (python-flake8)
select_template.py:62:12:error: E121 continuation line indentation is not a multiple of four (python-flake8)
select_template.py:63:21:error: E203 whitespace before ':' (python-flake8)
select_template.py:76:1:warning: F841 local variable 'template_line_obj' is assigned to but never used (python-flake8)
select_template.py:77:1:warning: F841 local variable 'account_period_obj' is assigned to but never used (python-flake8)
select_template.py:81:1:warning: F841 local variable 'entry' is assigned to but never used (python-flake8)
select_template.py:83:17:error: E222 multiple spaces after operator (python-flake8)
select_template.py:105:24:error: E225 missing whitespace around operator (python-flake8)
select_template.py:108:46:error: E231 missing whitespace after ',' (python-flake8)
select_template.py:118:1:warning: F841 local variable 'id_line' is assigned to but never used (python-flake8)
select_template.py:132:35:error: E231 missing whitespace after ',' (python-flake8)
select_template.py:150:1:warning: W391 blank line at end of file (python-flake8)

Keep up the good work.

Regards

Nicolas

Hello,

Thanks for the patch.

The diff looks good to me.

That said the module needs a general cleanup and review.

There is some oddities here and there and 
a simple pass of the wizard file on flake 8 gave the following output:

select_template.py:3:2:warning: W291 trailing whitespace (python-flake8)
select_template.py:22:31:error: E231 missing whitespace after ',' (python-flake8)
select_template.py:23:1:warning: F401 'time' imported but unused (python-flake8)
select_template.py:26:1:error: E302 expected 2 blank lines, found 1 (python-flake8)
select_template.py:30:101:error: E501 line too long (102 > 100 characters) (python-flake8)
select_template.py:33:33:error: E231 missing whitespace after ',' (python-flake8)
select_template.py:38:17:error: E222 multiple spaces after operator (python-flake8)
select_template.py:46:48:error: E231 missing whitespace after ',' (python-flake8)
select_template.py:58:101:error: E501 line too long (117 > 100 characters) (python-flake8)
select_template.py:62:12:error: E121 continuation line indentation is not a multiple of four (python-flake8)
select_template.py:63:21:error: E203 whitespace before ':' (python-flake8)
select_template.py:76:1:warning: F841 local variable 'template_line_obj' is assigned to but never used (python-flake8)
select_template.py:77:1:warning: F841 local variable 'account_period_obj' is assigned to but never used (python-flake8)
select_template.py:81:1:warning: F841 local variable 'entry' is assigned to but never used (python-flake8)
select_template.py:83:17:error: E222 multiple spaces after operator (python-flake8)
select_template.py:105:24:error: E225 missing whitespace around operator (python-flake8)
select_template.py:108:46:error: E231 missing whitespace after ',' (python-flake8)
select_template.py:118:1:warning: F841 local variable 'id_line' is assigned to but never used (python-flake8)
select_template.py:132:35:error: E231 missing whitespace after ',' (python-flake8)
select_template.py:150:1:warning: W391 blank line at end of file (python-flake8)

Keep up the good work.

Regards

Nicolas

review: Approve (no test, code review)

lp://qastaging/~agilebg/account-financial-tools/7.0-add_account_invoice_template_fixes updated on 2013-09-26

117. By Lorenzo Battistini on 2013-09-26: [IMP] PEP8

Revision history for this message

Lorenzo Battistini (elbati) wrote on 2013-09-26:

#

Hello Nicolas,
just made the changes, thanks.

Revision history for this message

bruno bottacini (bruno-bottacini) on 2013-10-31:

#

review: Approve

Account - Financial Tools

Merge lp://qastaging/~agilebg/account-financial-tools/7.0-add_account_invoice_template_fixes into lp://qastaging/~bruno-bottacini/account-financial-tools/7.0-add_account_invoice_template

Commit message

Description of the change

Preview Diff

Subscribers