OpenERP Product Attributes

Merge lp://qastaging/~agilebg/openerp-product-attributes/adding_pricelist_configurator_by_bom_7 into lp://qastaging/~product-core-editors/openerp-product-attributes/7.0

adding_pricelist_configurator_by_bom_7
Merge into 7.0

Proposed by Nicola Malcontenti - Agile BG on 2014-01-24

Status:	Needs review
Proposed branch:	lp://qastaging/~agilebg/openerp-product-attributes/adding_pricelist_configurator_by_bom_7
Merge into:	lp://qastaging/~product-core-editors/openerp-product-attributes/7.0
Diff against target:	659 lines (+615/-0) 8 files modified pricelist_configurator_by_bom/__init__.py (+23/-0) pricelist_configurator_by_bom/__openerp__.py (+65/-0) pricelist_configurator_by_bom/i18n/it.po (+117/-0) pricelist_configurator_by_bom/i18n/pricelist_configurator_by_bom.pot (+116/-0) pricelist_configurator_by_bom/pricelist_configurator_by_bom.py (+159/-0) pricelist_configurator_by_bom/pricelist_configurator_by_bom_view.xml (+89/-0) pricelist_configurator_by_bom/security/ir.model.access.csv (+9/-0) pricelist_configurator_by_bom/test/pricelist_configurator_by_bom.yml (+37/-0)
To merge this branch:	bzr merge lp://qastaging/~agilebg/openerp-product-attributes/adding_pricelist_configurator_by_bom_7
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Laetitia Gangloff (Acsone) (community)			Needs Resubmitting on 2014-07-09
Guewen Baconnier @ Camptocamp	code review		Approve on 2014-06-20
Akretion Team		2014-01-24	Pending
Review via email: mp+203026@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-01-24.

Description of the change

This module is a calculator that establishes the final product’s price based on
various margins on the single cost of the bill of material. In OpenERP the
product’s price is on the price list, every partner can have his price list and
every price list is connected to a product. So this is a calculator for the
price list.

This module provides a configurator where the user selects the final product
and the partner. The system propose the BOM with the cost of every component.
The User can finally set the margin for every component.

Revision history for this message

Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote on 2014-01-24:

Seems great, but why is a BoM mandatory?
One may want to generate such a pricelist over normal products, or do I miss something?

review: Needs Information

lp://qastaging/~agilebg/openerp-product-attributes/adding_pricelist_configurator_by_bom_7 updated on 2014-01-27

241. By Lorenzo Battistini on 2014-01-27: [IMP] description
242. By Lorenzo Battistini on 2014-01-27: [IMP] description

Revision history for this message

Lorenzo Battistini (elbati) wrote on 2014-01-27:

Hello Guewen, the main purpose of this module is to allow the user to apply different margins to BOM components
See (updated) description at http://bazaar.launchpad.net/~agilebg/openerp-product-attributes/adding_pricelist_configurator_by_bom_7/view/head:/pricelist_configurator_by_bom/__openerp__.py#L28
So, without BOM the configurator is useless I think

Revision history for this message

Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote on 2014-06-20:

Hi,

Thanks for the information!

Seems good to me!

review: Approve (code review)

Revision history for this message

Laetitia Gangloff (Acsone) (laetitia-gangloff) wrote on 2014-07-09:

This project is now hosted on https://github.com/OCA/product-attribute. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Revision history for this message

Alex Comba - Agile BG (tafaru) wrote on 2014-07-09:

Hi Laetitia,

I moved it to https://github.com/OCA/product-attribute/pull/7

Unmerged revisions

242. By Lorenzo Battistini on 2014-01-27: [IMP] description
241. By Lorenzo Battistini on 2014-01-27: [IMP] description
240. By Nicola Malcontenti - Agile BG on 2014-01-24: [FIX] Fixed update test
239. By Nicola Malcontenti - Agile BG on 2014-01-24: [FIX] fixed test
238. By Nicola Malcontenti - Agile BG on 2014-01-23: [FIX] fixed test
237. By Hurrinico on 2014-01-22: [FIX] test fixing
236. By Nicola Malcontenti - Agile BG on 2014-01-22: [FIX] added i18n, security and fix test
235. By Nicola Malcontenti - Agile BG on 2013-12-11: [FIX] Added Domain
234. By Nicola Malcontenti - Agile BG on 2013-12-11: [FIX] FIxed bug
233. By Nicola Malcontenti - Agile BG on 2013-12-11: [FIX] Added some changes to module