OpenERP Product Attributes

Merge lp://qastaging/~agilebg/openerp-product-attributes/adding_product_pack_7 into lp://qastaging/~product-core-editors/openerp-product-attributes/7.0

adding_product_pack_7
Merge into 7.0

Proposed by Lorenzo Battistini on 2013-11-19

Status:	Needs review
Proposed branch:	lp://qastaging/~agilebg/openerp-product-attributes/adding_product_pack_7
Merge into:	lp://qastaging/~product-core-editors/openerp-product-attributes/7.0
Diff against target:	1602 lines (+1545/-0) 11 files modified product_pack/__init__.py (+22/-0) product_pack/__openerp__.py (+48/-0) product_pack/i18n/ca.po (+163/-0) product_pack/i18n/de.po (+145/-0) product_pack/i18n/es.po (+164/-0) product_pack/i18n/it.po (+164/-0) product_pack/i18n/product_pack.pot (+155/-0) product_pack/i18n/pt.po (+149/-0) product_pack/pack.py (+484/-0) product_pack/pack_view.xml (+48/-0) product_pack/security/ir.model.access.csv (+3/-0)
To merge this branch:	bzr merge lp://qastaging/~agilebg/openerp-product-attributes/adding_product_pack_7
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Laetitia Gangloff (Acsone) (community)			Needs Resubmitting on 2014-07-09
Paulius Sladkevičius @ hbee (community)	test		Needs Fixing on 2014-02-12
Leonardo Pistone	code review, no test		Needs Fixing on 2013-11-25
Pedro Manuel Baeza	code review, no test	2013-11-19	Needs Fixing on 2013-11-19
Review via email: mp+195786@code.qastaging.launchpad.net

Description of the change

Based on the NAN_product_pack this module allows configuring products
as a collection of other products.
If such a product is added in a sale order or a purchase order, all the
products of the pack will be added automatically (when storing the order)
as children of the pack product

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2013-11-19:

Hi, Lorenzo.

Good addition!

You need to fix translation files, because they still point to nan_product_pack module.

Regards.

review: Needs Fixing (code review, no test)

lp://qastaging/~agilebg/openerp-product-attributes/adding_product_pack_7 updated on 2013-11-19

215. By Alex Comba - Agile BG on 2013-11-19: [FIX] Replaced nan_product_pack.pot by product_pack.pot

Revision history for this message

Alex Comba - Agile BG (tafaru) wrote on 2013-11-19:

Hi, Pedro.

I've just pushed the right pot file, please check if now it is ok.

Cheers.

Revision history for this message

Alex Comba - Agile BG (tafaru) wrote on 2013-11-19:

I forgot to fix the other translation files, I'll do it asap.

Regards.

Revision history for this message

Leonardo Pistone (lepistone) wrote on 2013-11-25:

Thank you Lorenzo, Alex.

- Translations, if they are old and/or incorrect, IMO we can remove them for now. You could leave whatever works for you (i.e. Italian) and remove everything else

- Defaults: lambda is not needed anymore

- I see some long, multi-line comments in the code. Maybe some could be moved in some more prominent place, like docstrings?

review: Needs Fixing (code review, no test)

Revision history for this message

Paulius Sladkevičius @ hbee (komsas) wrote on 2014-02-12:

There is need to prevent possibility to add product pack to itself, otherwise it's easy to get infinite recursion when 'stock_depends' is marked.

review: Needs Fixing (test)

lp://qastaging/~agilebg/openerp-product-attributes/adding_product_pack_7 updated on 2014-02-18

216. By Alex Comba - Agile BG on 2014-02-18: [REM] lambda not needed anymore

Revision history for this message

Ana Juaristi Olalde (ajuaristio) wrote on 2014-06-16:

Just to point it:

There was an error on nan_product_pack V6.X where after using it in a sale order, you duplicate that sale order, all the lines from pack used to stay on origin sale order.

nan_product_pack has been included in several repositories from different integrators, so depending the repository you used to migrate, bug could still be there. On the other side, it's very easy to fix. New sale_order_id not asigned on copied sale order lines but origin sale_order_id.

My 2 cents

lp://qastaging/~agilebg/openerp-product-attributes/adding_product_pack_7 updated on 2014-07-07

217. By Lorenzo Battistini on 2014-07-07: [MERGE] from main

Revision history for this message

Laetitia Gangloff (Acsone) (laetitia-gangloff) wrote on 2014-07-09:

This project is now hosted on https://github.com/OCA/product-attribute. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Revision history for this message

Alex Comba - Agile BG (tafaru) wrote on 2014-07-09:

Hi Laetitia,

I moved it to https://github.com/OCA/product-attribute/pull/6

Unmerged revisions

217. By Lorenzo Battistini on 2014-07-07: [MERGE] from main
216. By Alex Comba - Agile BG on 2014-02-18: [REM] lambda not needed anymore
215. By Alex Comba - Agile BG on 2013-11-19: [FIX] Replaced nan_product_pack.pot by product_pack.pot
214. By Alex Comba - Agile BG on 2013-10-03: [FIX] Get labels for boolean fields inside 'Pack' page
213. By Alex Comba - Agile BG on 2013-10-03: [IMP] Add PEP8 style check using flake8
212. By Alex Comba - Agile BG on 2013-08-26: [REM] empty spaces close to arguments
211. By Alex Comba - Agile BG on 2013-08-26: [REF] product_stock module porting to 7.0
210. By Alex Comba - Agile BG on 2013-08-26: [ADD] product_pack module 6.1 version