Sales - Workflow and Organization

Merge lp://qastaging/~agilebg/sale-wkfl/adding_account_fiscal_position_country_sale_7 into lp://qastaging/~sale-core-editors/sale-wkfl/7.0

  1. adding_account_fiscal_position_country_sale_7
  2. Merge into 7.0
Proposed by Alex Comba - Agile BG
Status: Rejected
Rejected by: Guewen Baconnier @ Camptocamp
Proposed branch: lp://qastaging/~agilebg/sale-wkfl/adding_account_fiscal_position_country_sale_7
Merge into: lp://qastaging/~sale-core-editors/sale-wkfl/7.0
Diff against target: 125 lines (+110/-0)
3 files modified
account_fiscal_position_country_sale/__init__.py (+23/-0)
account_fiscal_position_country_sale/__openerp__.py (+44/-0)
account_fiscal_position_country_sale/sale.py (+43/-0)
To merge this branch: bzr merge lp://qastaging/~agilebg/sale-wkfl/adding_account_fiscal_position_country_sale_7
Reviewer Review Type Date Requested Status
Lorenzo Battistini (community) Disapprove
Joël Grand-Guillaume @ camptocamp Needs Information
Guewen Baconnier @ Camptocamp Needs Information
Review via email: mp+182638@code.qastaging.launchpad.net

Description of the change

This branch adds the account_fiscal_position_country_sale porting to 7.0

The module extends the account_fiscal_position_country_sale to sale orders.

To post a comment you must log in.
Revision history for this message
Lorenzo Battistini (elbati) wrote :

account_fiscal_position_country_sale/sale_view.xml: is it still needed?

line 114: too long

review: Needs Fixing
lp://qastaging/~agilebg/sale-wkfl/adding_account_fiscal_position_country_sale_7 updated
22. By Alex Comba - Agile BG

[REM] unnecessary sale_view.xml

Revision history for this message
Alex Comba - Agile BG (tafaru) wrote :

Lorenzo, you were right: sale_view.xml is unnecessary, thanks!

Revision history for this message
Lorenzo Battistini (elbati) :
review: Approve
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Same remark than https://code.launchpad.net/~agilebg/account-invoicing/adding_account_fiscal_position_country_7/+merge/182636/comments/415438

review: Needs Information
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

+1 for having an explanation on this comment "Seems redundant with account_fiscal_position_rule in the https://code.launchpad.net/openerp-fiscal-rules project.
Do you have a reason for not reusing it?"

review: Needs Information
Revision history for this message
Lorenzo Battistini (elbati) wrote :

This MP can be rejected for the same reason as
https://code.launchpad.net/~agilebg/account-invoicing/adding_account_fiscal_position_country_7/+merge/182636
Thanks!

review: Disapprove

Unmerged revisions

22. By Alex Comba - Agile BG

[REM] unnecessary sale_view.xml

21. By Alex Comba - Agile BG

[FIX] method onchange_partner_id_fiscal_position

20. By Alex Comba - Agile BG

[REF] ported module account_fiscal_position_country_sale to ver. 7.0

19. By Alex Comba - Agile BG

[ADD] module account_fiscal_position_country_sale ver. 6.1

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches