Merge lp://qastaging/~ahasenack/landscape-charm/new-bundle-render into lp://qastaging/~landscape/landscape-charm/bundles-stable

Proposed by Andreas Hasenack
Status: Merged
Approved by: Andreas Hasenack
Approved revision: 25
Merged at revision: 17
Proposed branch: lp://qastaging/~ahasenack/landscape-charm/new-bundle-render
Merge into: lp://qastaging/~landscape/landscape-charm/bundles-stable
Diff against target: 466 lines (+182/-207)
9 files modified
.bzrignore (+1/-0)
Makefile (+21/-10)
charm-store (+68/-21)
landscape-dense-maas.yaml (+0/-59)
landscape-dense.yaml (+0/-59)
landscape-scalable.yaml (+0/-49)
render-bundles (+25/-4)
ubuntu-deps (+62/-0)
update-charm-revisions (+5/-5)
To merge this branch: bzr merge lp://qastaging/~ahasenack/landscape-charm/new-bundle-render
Reviewer Review Type Date Requested Status
Francis Ginther (community) Approve
🤖 Landscape Builder test results Approve
Ursula Junque (community) Approve
Review via email: mp+300891@code.qastaging.launchpad.net

Commit message

Sync bundle generation with what we have in bundles-trunk so that both produce the same set of files and directories. The content is still the same as it was before this branch.

Description of the change

Sync bundle generation with what we have in bundles-trunk so that both produce the same set of files and directories. The bundle content is still the same as it was before this branch.

I also added a small fix to the diff script so that it ignores the bundles.yaml (note the plural) file which is not used and is just an artifact of the charm store.

The diff is a bit big, here is what I did:
- merged with bundles-trunk
- removed the individual non-template yaml files representing each bundle: there are now generated and not part of the branch
- added --exclude bundles.yaml to the diff action in the charm-store diff

Everything else is a result of the merge from bundles-trunk.

To test:
charm login
charm whoami (to verify login). You may have to login on jujucharms.com with a browser before for all this to work (known bug in the charm store)

export CHARM_STORE_USER=landscape
make diff-charm-store

Should show no diff, because the rendered bundles match what is in the charm store currently. The rendered bundles are in the build/ directory.

Another test you can do:
make update-charm-revisions
bzr diff landscape-template.jinja2

Should show charm revision updates, still for the trusty series.

Bump to xenial:
bzr revert (if you ran the test above)
export EXTRA_UPDATE_ARGUMENTS="--series xenial"
make update-charm-revisions
bzr diff landscape-template.jinja2

That should bump all bundles to xenial and latest charm revisions

I just didn't test the actual push and publish commands (makefile targets).

To post a comment you must log in.
19. By Andreas Hasenack

Keep trusty as the default

20. By Andreas Hasenack

Added the charm package to the ubuntu dependencies to install.

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make render
Result: Success
Revno: 20
Branch: lp:~ahasenack/landscape-charm/new-bundle-render
Jenkins: https://ci.lscape.net/job/latch-test/5506/

review: Approve (test results)
21. By Andreas Hasenack

 - add the juju stable ppa if on trusty, because the charm tool isn't available
   on trusty proper.
 - run apt-get update if we decided we need to install something.

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make render
Result: Success
Revno: 21
Branch: lp:~ahasenack/landscape-charm/new-bundle-render
Jenkins: https://ci.lscape.net/job/latch-test/5507/

review: Approve (test results)
22. By Andreas Hasenack

Added python3-yaml to ubuntu-deps.

23. By Andreas Hasenack

Depend on deps in update-charm-revisions makefile target.

24. By Andreas Hasenack

We don't have apache2, juju-gui or nfs in our bundle anymore, so remove them from the update list.

Revision history for this message
Francis Ginther (fginther) wrote :

Please remove the push-charm-store and publish-charm-store makefile targets as the don't appear to be needed hear and removes the risk of someone accidentally using them to publish a test version of our bundles.

Otherwise looks good.

review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

Ooops, wrong state.

review: Needs Fixing
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make render
Result: Success
Revno: 24
Branch: lp:~ahasenack/landscape-charm/new-bundle-render
Jenkins: https://ci.lscape.net/job/latch-test/5509/

review: Approve (test results)
Revision history for this message
Ursula Junque (ursinha) wrote :

After all dependencies were fixed it's working fine. It's just odd that when I bump to xenial it changes haproxy charm to a precise one: https://pastebin.canonical.com/161523/. If that's expected and you address fginther's comments then +1.

review: Approve
25. By Andreas Hasenack

Fallback to trusty charms, not precise.

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make render
Result: Success
Revno: 25
Branch: lp:~ahasenack/landscape-charm/new-bundle-render
Jenkins: https://ci.lscape.net/job/latch-test/5510/

review: Approve (test results)
Revision history for this message
Francis Ginther (fginther) wrote :

Disregard my comment. Approve.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: