Merge ~ahasenack/ubuntu/+source/autofs:mantic-autofs-fix-ntlm-crammd5 into ubuntu/+source/autofs:ubuntu/devel
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | git-ubuntu bot | ||||
| Approved revision: | not available | ||||
| Merged at revision: | a93fc88e5322f18edd557f6d5c4d90b6b627f74b | ||||
| Proposed branch: | ~ahasenack/ubuntu/+source/autofs:mantic-autofs-fix-ntlm-crammd5 | ||||
| Merge into: | ubuntu/+source/autofs:ubuntu/devel | ||||
| Diff against target: |
96 lines (+33/-4) 6 files modified
debian/changelog (+12/-0) debian/patches/autofs-5.1.8-support-SCRAM-for-SASL-binding.patch (+1/-1) debian/patches/ntlm-crammd5-require-credentials.patch (+16/-0) debian/patches/series (+1/-0) debian/tests/control (+1/-1) debian/tests/ldap-map-sasl-auth (+2/-2) |
||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| git-ubuntu bot | Approve | ||
| Athos Ribeiro (community) | Approve | ||
| Canonical Server Core Reviewers | Pending | ||
| Canonical Server Reporter | Pending | ||
|
Review via email:
|
|||
Description of the change
This MP fixes:
- support for NTLM and CRAM-MD5 (bug #2023595): these were initially thought to be working, but closer inspection showed them to also be broken in the release pocket. I still need to fill out the SRU template for this one.
In the previous autofs merge I had opted to not fix this in the devel release, but since I'm SRUing this fix, I changed my mind. Initially I thought we shouldn't fix deprecated mechanisms (which NTLM and CRAM-MD5 are), but that's not the correct way to deprecate something (not fixing a bug). If we really want to deprecate these alrogorithms, then it should be a wider effort and they should be removed from cyrus-sasl2, for example.
Testing these is a bit involved, and I wrote a DEP8 test for that. This test will go over the shared secret mechanisms, as well as the kerberos ones (gssapi/
PPA: https:/
DEP8: green
Note: I disabled arm* builds because they were not starting, and I waited over 1h.
| Andreas Hasenack (ahasenack) wrote | # |
| Andreas Hasenack (ahasenack) wrote | # |
| Andreas Hasenack (ahasenack) wrote | # |
I still have to fill out the sru template for bug #2023595