Ubuntu Music App

Merge lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests into lp://qastaging/music-app/trusty

add-url-dispatcher-tests
Merge into trusty

Proposed by Andrew Hayzen on 2014-09-09

Status:	Work in progress
Proposed branch:	lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests
Merge into:	lp://qastaging/music-app/trusty
Diff against target:	280 lines (+124/-31) 7 files modified click/manifest.json.in (+7/-1) debian/control (+2/-0) music-app.qml (+24/-26) tests/autopilot/music_app/__init__.py (+6/-1) tests/autopilot/music_app/tests/__init__.py (+3/-3) tests/autopilot/music_app/tests/test_music.py (+60/-0) tests/autopilot/music_app/url_dispatcher.py (+22/-0)
To merge this branch:	bzr merge lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests
Related bugs:	Link a bug report

Reviewer	Review Type	Status
Ubuntu Phone Apps Jenkins Bot	continuous-integration	Approve on 2014-09-25
Leo Arias (community)	code review of the autopilot code	Approve on 2014-09-25
Andrew Hayzen		Abstain on 2014-09-25
Review via email: mp+233840@code.qastaging.launchpad.net

Commit message

* Add tests for url-dispatcher
* Fix for depends and allow autopkg support
* Fix for recent item added even with a bad url

Description of the change

* Add tests for url-dispatcher
* Fix for depends and allow autopkg support
* Fix for recent item added even with a bad url

TESTING:
This should be tested on device in the following way...

Install the new click package:
$ bzr branch lp:~andrew-hayzen/music-app/add-url-dispatcher-tests /tmp/add-dispatcher-tests
$ cd /tmp/add-dispatcher-tests
$ click-buddy --dir . --provision

To just run the changed tests:
$ ADT_AUTOPILOT_MODULE="-v music_app.tests.test_music.TestMainWindow.test_url_dispatcher_album_play" adt-run /tmp/add-dispatcher-tests --click com.ubuntu.music --- ssh -s adb
$ ADT_AUTOPILOT_MODULE="-v music_app.tests.test_music.TestMainWindow.test_url_dispatcher_music_play" adt-run /tmp/add-dispatcher-tests --click com.ubuntu.music --- ssh -s adb

To run all tests:
$ adt-run /tmp/add-dispatcher-tests --click com.ubuntu.music --- ssh -s adb

Note you need a newer adt if you are on trusty see instructions for install of autopkgtest here [0]

0 - http://www.theorangenotebook.com/2014/09/autopilot-test-runners.html

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-09:

FAILED: Continuous integration, rev:619
http://91.189.93.70:8080/job/music-app-ci/1111/
Executed test runs:
FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/257/console
FAILURE: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/335/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1111/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests updated on 2014-09-09

620. By Andrew Hayzen on 2014-09-09: * Move dispatcher to helper

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-09:

FAILED: Continuous integration, rev:620
http://91.189.93.70:8080/job/music-app-ci/1112/
Executed test runs:
FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/261/console
FAILURE: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/336/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1112/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests updated on 2014-09-09

621. By Andrew Hayzen on 2014-09-09: * Merge of trunk

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-09:

FAILED: Continuous integration, rev:621
http://91.189.93.70:8080/job/music-app-ci/1113/
Executed test runs:
FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/262/console
FAILURE: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/337/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1113/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-09:

FAILED: Continuous integration, rev:621
http://91.189.93.70:8080/job/music-app-ci/1114/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/269
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/269/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/338

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1114/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests updated on 2014-09-09

622. By Andrew Hayzen on 2014-09-09: * Fix for use of old artistName

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-09:

FAILED: Continuous integration, rev:622
http://91.189.93.70:8080/job/music-app-ci/1115/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/271
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/271/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/339

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1115/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests updated on 2014-09-09

623. By Andrew Hayzen on 2014-09-09: * Fix for unicode errors
* Jenkins debug

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-09:

FAILED: Continuous integration, rev:623
http://91.189.93.70:8080/job/music-app-ci/1116/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/272
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/272/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/340

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1116/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-09:

FAILED: Continuous integration, rev:623
http://91.189.93.70:8080/job/music-app-ci/1117/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/273
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/273/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/341

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1117/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests updated on 2014-09-09

624. By Andrew Hayzen on 2014-09-09: * Ensure url-dispatcher has started before calling it

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-09:

FAILED: Continuous integration, rev:624
http://91.189.93.70:8080/job/music-app-ci/1118/
Executed test runs:
FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/274/console
FAILURE: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/342/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1118/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests updated on 2014-09-09

625. By Andrew Hayzen on 2014-09-09: * Pep8 fix

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-09:

FAILED: Continuous integration, rev:625
http://91.189.93.70:8080/job/music-app-ci/1119/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/275
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/275/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/343

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1119/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests updated on 2014-09-10

626. By Andrew Hayzen on 2014-09-10: * Only run tests when in click environment

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-10:

PASSED: Continuous integration, rev:626
http://91.189.93.70:8080/job/music-app-ci/1121/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/278
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/278/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/345

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1121/rebuild

review: Approve (continuous-integration)

Revision history for this message

Leo Arias (elopio) wrote on 2014-09-10:

Some inline comments.

Revision history for this message

Andrew Hayzen (ahayzen) wrote on 2014-09-23:

#blocked as you cannot test due to bug 1370800

I've started resolving the comments, but we really need to fix ^^ bug first, otherwise you can't test if these works.

lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests updated on 2014-09-23

627. By Andrew Hayzen on 2014-09-16: * Various fixes for url-dispatcher
628. By Andrew Hayzen on 2014-09-23: * Merge of trunk

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-23:

FAILED: Continuous integration, rev:628
http://91.189.93.70:8080/job/music-app-ci/1135/
Executed test runs:
FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/503/console
FAILURE: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/359/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1135/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests updated on 2014-09-23

629. By Andrew Hayzen on 2014-09-23: * Fixes for pep8

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-23:

PASSED: Continuous integration, rev:629
http://91.189.93.70:8080/job/music-app-ci/1136/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/504
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/504/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/360

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1136/rebuild

review: Approve (continuous-integration)

lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests updated on 2014-09-23

630. By Andrew Hayzen on 2014-09-23: * Remove code comments

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-23:

PASSED: Continuous integration, rev:630
http://91.189.93.70:8080/job/music-app-ci/1137/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/505
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/505/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/361

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1137/rebuild

review: Approve (continuous-integration)

Revision history for this message

Leo Arias (elopio) wrote on 2014-09-24:

Some pita comments inline. This is pretty good, thanks Andrew.

lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests updated on 2014-09-24

631. By Andrew Hayzen on 2014-09-24: * Various fixes

Revision history for this message

Andrew Hayzen (ahayzen) wrote on 2014-09-24:

I would like to land this after this [0] has landed so blocking myself for a bit.

0 - https://code.launchpad.net/~andrew-hayzen/music-app/ap-mocking-fixes/+merge/235821

review: Needs Fixing

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-24:

PASSED: Continuous integration, rev:631
http://91.189.93.70:8080/job/music-app-ci/1139/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/524
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/524/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/363

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1139/rebuild

review: Approve (continuous-integration)

lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests updated on 2014-09-25

632. By Andrew Hayzen on 2014-09-25: * Merge of trunk

Revision history for this message

Andrew Hayzen (ahayzen) wrote on 2014-09-25:

Unblocking myself as the other mp has landed.

review: Abstain

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-25:

PASSED: Continuous integration, rev:632
http://91.189.93.70:8080/job/music-app-ci/1142/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/538
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/538/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/366

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1142/rebuild

review: Approve (continuous-integration)

Revision history for this message

Leo Arias (elopio) wrote on 2014-09-25:

ahayzen_: as you added the decorator to the url dispatcher call, you don't need
235 + logger.debug("Calling URL Dispatcher - " + path)
elopio, ah yes good spot ;)
ahayzen_: and last pita comment, pep8 recommends to capitalize all the letter of an abbreviation.
so URLDispatcher instead of UrlDispatcher.
elopio, ah yes ok i'll do that
ahayzen_: I'm really happy with your python code. I don't know much about the QML code, so it would be safer if you get somebody to review that part.

review: Approve (code review of the autopilot code)

lp://qastaging/~ahayzen/music-app/add-url-dispatcher-tests updated on 2014-09-25

633. By Andrew Hayzen on 2014-09-25: * Removal of extra debugging
* Rename UrlDispatcher to URLDispatcher

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-25:

PASSED: Continuous integration, rev:633
http://91.189.93.70:8080/job/music-app-ci/1143/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/539
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/539/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/367

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1143/rebuild

review: Approve (continuous-integration)

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-10-07:

What's up with this mp?

Revision history for this message

Victor Thompson (vthompson) wrote on 2014-10-08:

In my opinion we could do either of the following:

1. Finish review and merge this into trunk, then merge the change into the remix branch. Benefit being that the 2 added tests get some usage early on, negative being that this is extra work if something isn't quite right.
2. Create a new MP for this once remix is trunk. Benefit being we can still focus on our redesign without possible distraction.

#2 might be the safest, but #1 might be preferable if we want these tests in as early as possible.

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-10-09:

I'd vote to go with the second; heads down on remix. Thanks.

Revision history for this message

Victor Thompson (vthompson) wrote on 2014-10-09:

I'll put this as a WIP as it will probably be resubmitted.

Unmerged revisions

633. By Andrew Hayzen on 2014-09-25: * Removal of extra debugging
* Rename UrlDispatcher to URLDispatcher
632. By Andrew Hayzen on 2014-09-25: * Merge of trunk
631. By Andrew Hayzen on 2014-09-24: * Various fixes
630. By Andrew Hayzen on 2014-09-23: * Remove code comments
629. By Andrew Hayzen on 2014-09-23: * Fixes for pep8
628. By Andrew Hayzen on 2014-09-23: * Merge of trunk
627. By Andrew Hayzen on 2014-09-16: * Various fixes for url-dispatcher
626. By Andrew Hayzen on 2014-09-10: * Only run tests when in click environment
625. By Andrew Hayzen on 2014-09-09: * Pep8 fix
624. By Andrew Hayzen on 2014-09-09: * Ensure url-dispatcher has started before calling it