Ubuntu Music App

Merge lp://qastaging/~ahayzen/music-app/ap-new-emulators-1341681 into lp://qastaging/music-app/trusty

ap-new-emulators-1341681
Merge into trusty

Proposed by Andrew Hayzen on 2014-08-18

Status:

Merged

Approved by:

Victor Thompson on 2014-08-18

Approved revision:

583

Merged at revision:

583

Proposed branch:

lp://qastaging/~ahayzen/music-app/ap-new-emulators-1341681

Merge into:

lp://qastaging/music-app/trusty

Diff against target:

580 lines (+259/-267)

3 files modified

tests/autopilot/music_app/__init__.py (+253/-0)
tests/autopilot/music_app/emulators.py (+0/-261)
tests/autopilot/music_app/tests/__init__.py (+6/-6)

To merge this branch:

bzr merge lp://qastaging/~ahayzen/music-app/ap-new-emulators-1341681

Undecided

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Victor Thompson		2014-08-18	Approve on 2014-08-18
Nicholas Skaggs (community)		2014-08-18	Approve on 2014-08-18
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2014-08-18
Review via email: mp+231256@code.qastaging.launchpad.net

Commit message

* Switch to custom proxy object emulator, instead of calling via old emulators module

Description of the change

* Switch to custom proxy object emulator, instead of calling via old emulators module

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-08-18:

PASSED: Continuous integration, rev:583
http://91.189.93.70:8080/job/music-app-ci/1038/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1609
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1609/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/262

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1038/rebuild

review: Approve (continuous-integration)

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-08-18:

LGTM

review: Approve

Revision history for this message

Victor Thompson (vthompson) wrote on 2014-08-18:

Looks good to me. I was going to suggest we move the class docstring to be immediately after the class declaration, as that seems to be the way it's usually done, but it was like that before.

review: Approve