Ubuntu Music App

Merge lp://qastaging/~ahayzen/music-app/duration-count-down into lp://qastaging/music-app/remix

  1. duration-count-down
  2. Merge into remix
Proposed by Andrew Hayzen
Status: Work in progress
Proposed branch: lp://qastaging/~ahayzen/music-app/duration-count-down
Merge into: lp://qastaging/music-app/remix
Diff against target: 45 lines (+5/-2)
1 file modified
MusicNowPlaying.qml (+5/-2)
To merge this branch: bzr merge lp://qastaging/~ahayzen/music-app/duration-count-down
Reviewer Review Type Date Requested Status
Victor Thompson Needs Fixing
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+242436@code.qastaging.launchpad.net

Commit message

* Switch the duration label to count down

Description of the change

* Switch the duration label to count down

It has been suggested a few times to have the duration label counting down. This switches the label to be the (duration - position), I'm unsure whether using a minus sign before the duration label would be preferred? All of the branch needs design review.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:746
http://91.189.93.70:8080/job/music-app-ci/1162/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/331
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/331/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/14

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1162/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Victor Thompson (vthompson) wrote :

I prefer having the total duration on the right, but we'll see what design thinks. I tested both Spotify and Google Music on Android and they both list the total duration on the right.

Reply
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

I agree Walkman and VLC player do the same on Android, this was just a suggestion from some feedback so I felt it was worth exploring.

Reply
Revision history for this message
Victor Thompson (vthompson) wrote :

My HTC Sense Music player actually does this. But it has the minus sign in front. That's the only data point I can find.

Reply
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

For info, spotify on desktop shows "Duration" on the right.
Rhythmbox and PopcornTime (video player) show "Position / Duration" at the left end.
Banshee shows "Position of Duration" underneath.
iTunes on iOS shows Position at one end and "-Remaining" at the other.

So no real consensus, but I'm happy with this change.

review: Approve
Reply
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

#blocked needs design input

Reply
Revision history for this message
Victor Thompson (vthompson) wrote :

This change will need to be rebased onto trunk (lp:music-app/refactor) if it is to be landed.

review: Needs Fixing
Reply

Unmerged revisions

746. By Andrew Hayzen

* Switch the duration label to count down

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches