Merge lp://qastaging/~ahayzen/music-app/fix-1482545-swipe-in-now-playing into lp://qastaging/music-app

Proposed by Andrew Hayzen
Status: Needs review
Proposed branch: lp://qastaging/~ahayzen/music-app/fix-1482545-swipe-in-now-playing
Merge into: lp://qastaging/music-app
Prerequisite: lp://qastaging/~music-app-dev/music-app/media-hub-bg-playlists-rework
Diff against target: 234 lines (+171/-26)
2 files modified
app/components/NowPlayingFullView.qml (+170/-26)
debian/changelog (+1/-0)
To merge this branch: bzr merge lp://qastaging/~ahayzen/music-app/fix-1482545-swipe-in-now-playing
Reviewer Review Type Date Requested Status
Victor Thompson Needs Information
Andrew Hayzen Disapprove
Jenkins Bot continuous-integration Approve
Review via email: mp+281045@code.qastaging.launchpad.net

Commit message

* Swipe left and right of album in full now playing now slide

Description of the change

* Swipe left and right of album in full now playing now slide

Note that this is broken in shuffle mode due to media-hub giving the wrong values (bug 1528072)

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

#blocked by bug 1528072

review: Disapprove
Revision history for this message
Victor Thompson (vthompson) wrote :

This change also isn't as nice on the desktop. Is there a way we could show the blurred bg and still support this animation?

review: Needs Information
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

For the desktop I was assuming that it would have it's converged view, so haven't yet tested it on the desktop.

Unmerged revisions

914. By Andrew Hayzen

* Swipe left and right of album in full now playing now slide

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches