Ubuntu Music App

Merge lp://qastaging/~ahayzen/music-app/qml-unit-test-filenames into lp://qastaging/music-app

  1. qml-unit-test-filenames
  2. Merge into trunk
Proposed by Andrew Hayzen
Status: Needs review
Proposed branch: lp://qastaging/~ahayzen/music-app/qml-unit-test-filenames
Merge into: lp://qastaging/music-app
Diff against target: 292 lines (+231/-0)
9 files modified
README.unittests (+47/-0)
app/components/Player.qml (+1/-0)
debian/changelog (+3/-0)
tests/CMakeLists.txt (+1/-0)
tests/unit/CMakeLists.txt (+6/-0)
tests/unit/generate_files.sh (+16/-0)
tests/unit/setup_run_locally.sh (+17/-0)
tests/unit/setup_run_on_device.sh (+24/-0)
tests/unit/tst_filenames.qml (+116/-0)
To merge this branch: bzr merge lp://qastaging/~ahayzen/music-app/qml-unit-test-filenames
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Victor Thompson Needs Fixing
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+270512@code.qastaging.launchpad.net

Commit message

* Add qml unit tests for different filenames with media-hub and mediascanner

Description of the change

* Add qml unit tests for different filenames with media-hub and mediascanner

This add a set of qml unit tests, which can be run manually to test that all the possible filenames in the ascii table can be played/found. (Plan is to add this to the manual tests list once that is in the repo).

To post a comment you must log in.
lp://qastaging/~ahayzen/music-app/qml-unit-test-filenames updated
892. By Andrew Hayzen

* Merge of trunk

893. By Andrew Hayzen

* Update code comments

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:892
http://91.189.93.70:8080/job/music-app-ci/1379/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/231

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1379/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:893
http://91.189.93.70:8080/job/music-app-ci/1380/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/232

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1380/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Victor Thompson (vthompson) wrote :

Just briefly looking this over. I think we should also add a README.unittests with instructions on running the tests. Also, if we have a script to run on the device, would it also make sense to have a script that runs all the tests locally?

review: Needs Fixing
Reply
lp://qastaging/~ahayzen/music-app/qml-unit-test-filenames updated
894. By Andrew Hayzen

* Add README.unittests and setup_run_locally.sh files

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

* Add README.unittests and setup_run_locally.sh files

Please retest :-)

Reply
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:894
http://91.189.93.70:8080/job/music-app-ci/1384/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/236

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1384/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Victor Thompson (vthompson) wrote :

Things to fix:

1. Please update to UC 1.3.
2. I also experienced your FIXME when running on the device. I think it's because the password isn't echoed back through adb--my password shows up in the terminal. There should be a way to echo it back.

Things to consider:

1. Oh dear that tone for the test files is kind of annoying. :)
2. Will it still make sense to have this run locally to test mh3 bg playlists? I think we might need to update the installation requirements before running the tests to install media hub. The unit tests fail locally on Xenial for me.
3. Is there a way to have the Ubuntu Application Test close after the unit tests run?

review: Needs Fixing
Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:894
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/10/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/143/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/10/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

894. By Andrew Hayzen

* Add README.unittests and setup_run_locally.sh files

893. By Andrew Hayzen

* Update code comments

892. By Andrew Hayzen

* Merge of trunk

891. By Andrew Hayzen

* Tweaks to test files

890. By Andrew Hayzen

* Merge of trunk

889. By Andrew Hayzen

* Skip invalid file paths
* Test metadata from mediascanner is correct
* Improve init and how data is exposed

888. By Andrew Hayzen

* First round of changes for unit tests

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches