Ubuntu Music App

Merge lp://qastaging/~ahayzen/music-app/refactor-async-loader-pages into lp://qastaging/music-app

  1. refactor-async-loader-pages
  2. Merge into trunk
Proposed by Andrew Hayzen
Status: Work in progress
Proposed branch: lp://qastaging/~ahayzen/music-app/refactor-async-loader-pages
Merge into: lp://qastaging/music-app
Diff against target: 355 lines (+132/-36)
7 files modified
app/components/ColumnFlow.qml (+20/-3)
app/components/Flickables/CardView.qml (+1/-7)
app/components/MusicToolbar.qml (+1/-0)
app/music-app.qml (+107/-26)
app/ui/Albums.qml (+1/-0)
app/ui/Genres.qml (+1/-0)
app/ui/Playlists.qml (+1/-0)
To merge this branch: bzr merge lp://qastaging/~ahayzen/music-app/refactor-async-loader-pages
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Victor Thompson Needs Information
Review via email: mp+248477@code.qastaging.launchpad.net

Commit message

* Load pages in async, the current page first then the other pages

Description of the change

* Load pages in async, the current page first then the other pages

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:834
http://91.189.93.70:8080/job/music-app-refactor-ci/20/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/980
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/980/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-vivid-amd64-ci/20

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-refactor-ci/20/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Victor Thompson (vthompson) wrote :

The reason this makes a difference is because we are now waiting to load the Songs tab until it becomes visible. I'm not sure the others really need to be loaded asynchronously--as they currently behave this way internally anyway.

I'd also like us to revisit what it means to load things in this fashion. There's a loading time hit for every CardView filled tab (and now ListView) we currently have in the app. So with this MP it's every tab. This makes it a bit annoying (slow and distracting, as well) to browse from tab to tab. I think a better idea might be to load things asynchronously, but do so upon app startup. Maybe wait until the current view has finished, then load the other views. This would mean the below Loaders would be made "active: true" and the CardView would be made to load when not visible. But we should discuss this.

Since this isn't very important for the goal of refactoring, let's think this through a bit more before making a decision.

review: Needs Information
Reply
lp://qastaging/~ahayzen/music-app/refactor-async-loader-pages updated
835. By Andrew Hayzen

* Load the other pages/tabs once the first is complete

836. By Andrew Hayzen

* Merge of trunk

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:836
http://91.189.93.70:8080/job/music-app-refactor-ci/27/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/1009
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/1009/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-vivid-amd64-ci/27

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-refactor-ci/27/rebuild

review: Approve (continuous-integration)
Reply
lp://qastaging/~ahayzen/music-app/refactor-async-loader-pages updated
837. By Andrew Hayzen

* Merge of trunk

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

We are going to make a version for trunk first, therefore marking this as WIP for now.

Reply
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:837
http://91.189.93.70:8080/job/music-app-refactor-ci/31/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/1016
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/1016/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-refactor-vivid-amd64-ci/31

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-refactor-ci/31/rebuild

review: Approve (continuous-integration)
Reply
lp://qastaging/~ahayzen/music-app/refactor-async-loader-pages updated
838. By Andrew Hayzen

* Allow empty ColumnFlow's to load when not visible

839. By Andrew Hayzen

* Pull of /refactor

840. By Andrew Hayzen

* Pull of changes to ColumnFlow.qml in async-loader-pages that teach it about preloading

841. By Andrew Hayzen

* Wait until the toolbar has shown before loading further pages

Unmerged revisions

841. By Andrew Hayzen

* Wait until the toolbar has shown before loading further pages

840. By Andrew Hayzen

* Pull of changes to ColumnFlow.qml in async-loader-pages that teach it about preloading

839. By Andrew Hayzen

* Pull of /refactor

838. By Andrew Hayzen

* Allow empty ColumnFlow's to load when not visible

837. By Andrew Hayzen

* Merge of trunk

836. By Andrew Hayzen

* Merge of trunk

835. By Andrew Hayzen

* Load the other pages/tabs once the first is complete

834. By Andrew Hayzen

* Load pages in async and only when visible

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches