Ubuntu Music App

Merge lp://qastaging/~ahayzen/music-app/refactor-recent-detection into lp://qastaging/music-app/remix

  1. refactor-recent-detection
  2. Merge into remix
Proposed by Andrew Hayzen
Status: Work in progress
Proposed branch: lp://qastaging/~ahayzen/music-app/refactor-recent-detection
Merge into: lp://qastaging/music-app/remix
Diff against target: 156 lines (+32/-53)
3 files modified
common/SongsPage.qml (+3/-39)
music-app.qml (+27/-13)
playlists.js (+2/-1)
To merge this branch: bzr merge lp://qastaging/~ahayzen/music-app/refactor-recent-detection
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Music App Developers Pending
Review via email: mp+242417@code.qastaging.launchpad.net

Commit message

* Change the recent detection to be done by the source of the playing track
* Track songs of less than 10s in metrics and recent

Description of the change

* Change the recent detection to be done by the source of the playing track
* Track songs of less than 10s in metrics and recent

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:746
http://91.189.93.70:8080/job/music-app-ci/1160/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/329
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/329/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/12

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1160/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Victor Thompson (vthompson) wrote :

This causes an interesting case when the user renames a playlist after its contents were added to the queue.

1. Play a playlist.
2. Rename the playlist.
3. Play the next track in the playlist by hitting the forward button.
4. Navigate to Recent and note that the wrong playlist is listed after 10 seconds

Reply
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

#blocked needs design input (in general for refactor of recent - what is the end goal?)

Reply

Unmerged revisions

746. By Andrew Hayzen

* Change the recent detection to be done by the source of the playing track
* Track songs of less than 10s in metrics and recent

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches