Ubuntu Music App

Merge lp://qastaging/~ahayzen/music-app/remix-queue-split into lp://qastaging/music-app/remix

remix-queue-split
Merge into remix

Proposed by Andrew Hayzen on 2014-11-15

Status:	Work in progress
Proposed branch:	lp://qastaging/~ahayzen/music-app/remix-queue-split
Merge into:	lp://qastaging/music-app/remix
Diff against target:	978 lines (+449/-383) 4 files modified MusicNowPlaying.qml (+25/-344) MusicQueue.qml (+368/-0) tests/autopilot/music_app/__init__.py (+19/-33) tests/autopilot/music_app/tests/test_music.py (+37/-6)
To merge this branch:	bzr merge lp://qastaging/~ahayzen/music-app/remix-queue-split
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Victor Thompson		2014-11-15	Needs Fixing on 2014-11-15
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Needs Fixing on 2014-11-15
Review via email: mp+241884@code.qastaging.launchpad.net

Commit message

* Split the MusicQueue and MusicNowPlaying into two pages (still act like toggles though)

Description of the change

* Split the MusicQueue and MusicNowPlaying into two pages (still act like toggles though)

Note this is in prep for bottom edge development.

Please test both pages in great detail, remember things like header actions/multiselect etc :)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-11-15:

FAILED: Continuous integration, rev:741
http://91.189.93.70:8080/job/music-app-ci/1154/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/235
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/235/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/6

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1154/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Victor Thompson (vthompson) wrote on 2014-11-15:

When clicking on the toolbar while in Queue view the following error is produced:

file:///home/victor/Development/remix-queue-split/music-app.qml:1047: Error: Cannot assign to non-existent property "isListView"

review: Needs Fixing

Revision history for this message

Victor Thompson (vthompson) wrote on 2014-11-15:

This also causes the Queue to be rebuilt each time it is shown. Currently it is fairly distracting when it is doing so. Do we need to rebuild it each time?