Ubuntu Music App

Merge lp://qastaging/~ahayzen/music-app/single-repeat into lp://qastaging/music-app/remix

single-repeat
Merge into remix

Proposed by Andrew Hayzen on 2014-11-20

Status:

Work in progress

Proposed branch:

lp://qastaging/~ahayzen/music-app/single-repeat

Merge into:

lp://qastaging/music-app/remix

Diff against target:

261 lines (+212/-2)

3 files modified

MusicNowPlaying.qml (+23/-1)
Player.qml (+5/-1)
images/media-playlist-repeat-single.svg (+184/-0)

To merge this branch:

bzr merge lp://qastaging/~ahayzen/music-app/single-repeat

Medium

In Progress

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Needs Fixing on 2014-11-20
Music App Developers		2014-11-20	Pending
Review via email: mp+242427@code.qastaging.launchpad.net

Commit message

* Implement single repeat mode

Description of the change

* Implement single repeat mode

Proposing for initial code review, this probably needs design review of the icon and flow of repeat modes.

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-11-20:

FAILED: Continuous integration, rev:746
http://91.189.93.70:8080/job/music-app-ci/1161/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/330
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/330/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/13

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1161/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Victor Thompson (vthompson) wrote on 2014-11-21:

I think this looks great. However, we should hold off on landing until we get verification from design that we want this functionality and want it implemented this way.

Design, here's what the "single repeat" state of the Repeat button looks like: http://i.imgur.com/pGFpo1v.png

The flow is: Repeat off -> Repeat the queue list -> Repeat the current song.

Revision history for this message

Andrew Hayzen (ahayzen) wrote on 2014-12-09:

#blocked needs design input

Revision history for this message

Andrew Hayzen (ahayzen) wrote on 2015-05-04:

This will be done as part of the background-playlists work now, so will need reworking, therefore WIP.