Ubuntu Music App

Merge lp://qastaging/~ahayzen/music-app/snap-devmode into lp://qastaging/music-app

  1. snap-devmode
  2. Merge into trunk
Proposed by Andrew Hayzen
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 1038
Merged at revision: 1026
Proposed branch: lp://qastaging/~ahayzen/music-app/snap-devmode
Merge into: lp://qastaging/music-app
Diff against target: 153 lines (+113/-2)
3 files modified
CMakeLists.txt (+2/-2)
snap/music-app.wrapper (+12/-0)
snap/snapcraft.yaml (+99/-0)
To merge this branch: bzr merge lp://qastaging/~ahayzen/music-app/snap-devmode
Reviewer Review Type Date Requested Status
Renato Araujo Oliveira Filho (community) Approve
Jenkins Bot continuous-integration Approve
Music App Developers Pending
Review via email: mp+321855@code.qastaging.launchpad.net

Commit message

* Add snap packaging for the music-app to run in devmode (it assumes mediascanner is running on the host)

Description of the change

* Add snap packaging for the music-app to run in devmode (it assumes mediascanner is running on the host)

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:1035
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/112/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/1036/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/112/rebuild

review: Approve (continuous-integration)
lp://qastaging/~ahayzen/music-app/snap-devmode updated
1036. By Andrew Hayzen

* Remove desktop_file_hint

1037. By Andrew Hayzen

* Add

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:1036
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/113/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/1037/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/113/rebuild

review: Approve (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:1037
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/114/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/1038/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/114/rebuild

review: Approve (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

just some inline comments.

lp://qastaging/~ahayzen/music-app/snap-devmode updated
1038. By Andrew Hayzen

* Be more explicit about gstreamer plugins

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:1038
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/115/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/1039/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/115/rebuild

review: Approve (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches