Ubuntu Weather App

Merge lp://qastaging/~ahayzen/ubuntu-weather-app/fix-1583169-add-updated-at-text into lp://qastaging/ubuntu-weather-app

fix-1583169-add-updated-at-text
Merge into reboot

Proposed by Andrew Hayzen on 2016-08-17

Status:

Merged

Approved by:

Andrew Hayzen on 2017-04-12

Approved revision:

253

Merged at revision:

266

Proposed branch:

lp://qastaging/~ahayzen/ubuntu-weather-app/fix-1583169-add-updated-at-text

Merge into:

lp://qastaging/ubuntu-weather-app

Diff against target:

172 lines (+78/-6)

5 files modified

app/components/HomeTempInfo.qml (+34/-1)
app/ui/LocationPane.qml (+6/-0)
debian/changelog (+9/-1)
manifest.json.in (+1/-1)
po/com.ubuntu.weather.pot (+28/-3)

To merge this branch:

bzr merge lp://qastaging/~ahayzen/ubuntu-weather-app/fix-1583169-add-updated-at-text

Wishlist

Fix Committed

Link a bug report

Reviewer	Review Type	Status
Jenkins Bot	continuous-integration	Approve on 2017-04-12
Michael Sheldon (community)		Approve on 2017-04-12
Andrew Hayzen		Abstain on 2017-04-12
Review via email: mp+303188@code.qastaging.launchpad.net

Commit message

* Add support for showing updated X minutes ago

Description of the change

* Add support for showing updated X minutes ago

Revision history for this message

Andrew Hayzen (ahayzen) wrote on 2016-08-17:

We are going to get design to review this first.

review: Needs Information

Revision history for this message

Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote on 2016-08-31:

PASSED: Continuous integration, rev:250
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/72/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/970/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/72/rebuild

review: Approve (continuous-integration)

lp://qastaging/~ahayzen/ubuntu-weather-app/fix-1583169-add-updated-at-text updated on 2017-04-12

251. By Andrew Hayzen on 2017-04-12: * Pull of trunk

Revision history for this message

Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote on 2017-04-12:

PASSED: Continuous integration, rev:251
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/75/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/1042/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/75/rebuild

review: Approve (continuous-integration)

Revision history for this message

Andrew Hayzen (ahayzen) wrote on 2017-04-12:

Testing:
- Open the weather for a location
- Wait for a long period of time check that the "updated recently" changes to "updated N minutes ago"
- Refresh (pull from top) the location to refresh
- It should now change back to "updated recently"

review: Abstain

lp://qastaging/~ahayzen/ubuntu-weather-app/fix-1583169-add-updated-at-text updated on 2017-04-12