Ubuntu Weather App

Merge lp://qastaging/~ahayzen/ubuntu-weather-app/fix-control-depends-01 into lp://qastaging/ubuntu-weather-app

  1. fix-control-depends-01
  2. Merge into reboot
Proposed by Andrew Hayzen
Status: Needs review
Proposed branch: lp://qastaging/~ahayzen/ubuntu-weather-app/fix-control-depends-01
Merge into: lp://qastaging/ubuntu-weather-app
Diff against target: 175 lines (+88/-4)
6 files modified
app/components/NoAPIKeyErrorStateComponent.qml (+2/-2)
debian/changelog (+1/-0)
debian/control (+2/-0)
tests/autopilot/ubuntu_weather_app/__init__.py (+26/-0)
tests/autopilot/ubuntu_weather_app/fixture_setup.py (+52/-0)
tests/autopilot/ubuntu_weather_app/tests/__init__.py (+5/-2)
To merge this branch: bzr merge lp://qastaging/~ahayzen/ubuntu-weather-app/fix-control-depends-01
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Needs Fixing
Victor Thompson Needs Information
Review via email: mp+282241@code.qastaging.launchpad.net

Commit message

* Fixes for missing packages in debian/control

Description of the change

* Fixes for missing packages in debian/control

On a blank install in Wily I had to manually install these packages to get the weather-app to run.

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:196
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/84/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/350/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/84/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Victor Thompson (vthompson) wrote :

I'm not sure why this is failing--but it looks good to me.

Could you also fix app/components/NoAPIKeyErrorStateComponent.qml to use Ubuntu.Components 1.3. Not sure how that got set to 1.5... Seems silly to make an MP just for that.

review: Needs Information
Reply
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

The first failure is due to the location allow/deny appearing, the same as clock. The other two appear to be due to not enough locations in the list, I assume because it has no current location or it wasn't added correctly.

Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:197
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/150/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/429/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/150/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:198
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/151/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/430/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/151/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:199
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/152/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/431/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/152/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:200
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/153/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/432/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/153/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:201
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/154/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/433/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/154/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:202
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/155/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/434/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/155/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:202
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/156/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/435/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/156/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/weather-app-autolanding/412/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1565/console

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

202. By Andrew Hayzen

* Extra debugging

201. By Andrew Hayzen

* Add GeolocationPermissionRequest helper

200. By Andrew Hayzen

* Split stop and start commands

199. By Andrew Hayzen

* Run location service in background

198. By Andrew Hayzen

* Add fixture to fix location issues
* Update copyright years

197. By Andrew Hayzen

* Fix for incorrect Ubuntu.Components version

196. By Andrew Hayzen

Fixes for missing packages in debian/control

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: