Merge lp://qastaging/~ahayzen/webbrowser-app/browser-colour-update-001 into lp://qastaging/webbrowser-app/staging
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://qastaging/~ahayzen/webbrowser-app/browser-colour-update-001 |
| Merge into: | lp://qastaging/webbrowser-app/staging |
| Diff against target: |
1026 lines (+244/-131) 29 files modified
src/app/ChromeBase.qml (+6/-3) src/app/ChromeButton.qml (+3/-2) src/app/Favicon.qml (+1/-0) src/app/webbrowser/AddressBar.qml (+8/-2) src/app/webbrowser/BookmarksFoldersViewWide.qml (+1/-1) src/app/webbrowser/Browser.qml (+25/-5) src/app/webbrowser/Chrome.qml (+17/-15) src/app/webbrowser/Highlight.js (+1/-1) src/app/webbrowser/IncognitoPalette.qml (+36/-0) src/app/webbrowser/IndeterminateProgressBar.qml (+1/-1) src/app/webbrowser/ListViewHighlight.qml (+2/-2) src/app/webbrowser/NavigationBar.qml (+4/-4) src/app/webbrowser/NewTabView.qml (+7/-3) src/app/webbrowser/NewTabViewWide.qml (+5/-3) src/app/webbrowser/PublicPalette.qml (+32/-0) src/app/webbrowser/Suggestion.qml (+26/-54) src/app/webbrowser/Suggestions.qml (+8/-5) src/app/webbrowser/TabChrome.qml (+0/-1) src/app/webbrowser/TabItem.qml (+8/-9) src/app/webbrowser/TabsBar.qml (+23/-10) src/app/webbrowser/ToolbarAction.qml (+1/-1) src/app/webbrowser/UrlDelegate.qml (+2/-2) src/app/webbrowser/UrlDelegateWide.qml (+2/-2) src/app/webbrowser/UrlPreviewDelegate.qml (+1/-0) src/app/webbrowser/assets/tab-active-private@27.sci (+5/-0) src/app/webbrowser/assets/tab-hover-private@27.sci (+5/-0) src/app/webbrowser/assets/tab-non-active-desktop@27.sci (+0/-5) src/app/webbrowser/assets/tab-non-active-private@27.sci (+5/-0) src/app/webbrowser/webbrowser-app.qml (+9/-0) |
| To merge this branch: | bzr merge lp://qastaging/~ahayzen/webbrowser-app/browser-colour-update-001 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Olivier Tilloy | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
* Various colour updates and improvements to theming
* Create Incognito and Public palettes for private vs public browsing and use in the chrome
* Correctly show divider between chrome and content when not showing the new tab view
* Reduce the tab bar height and height above as per design
* Update Suggestions to use new ListItem and ListItemLayout to match design
* Until bug 1638337 is fixed, set a background colour in the suggestion list items
Description of the change
* Various colour updates and improvements to theming
* Create Incognito and Public palettes for private vs public browsing and use in the chrome
* Correctly show divider between chrome and content when not showing the new tab view
* Reduce the tab bar height and height above as per design
* Update Suggestions to use new ListItem and ListItemLayout to match design
* Until bug 1638337 is fixed, set a background colour in the suggestion list items
| Olivier Tilloy (osomon) wrote | # |
| Andrew Hayzen (ahayzen) wrote | # |
Unmerged revisions
- 1569. By Andrew Hayzen
-
* Various tidyups
- 1568. By Andrew Hayzen
-
* Ensure that in private browser correct colour is used for stock_website icon
- 1567. By Andrew Hayzen
-
* Merge of lp:webbrowser-app/staging
- 1566. By Andrew Hayzen
-
* Correcrtly show divider between chrome and content when not showing the new tab view
* Reduce the tab bar height even further as per design
* Until bug 1638337 is fixed, set a background colour in the suggestion list items - 1565. By Andrew Hayzen
-
* Narrow mode tab colour fixed
* Suggestion now used new ListItem and ListItemLayout to match design
* Reduce height above tab to match design
* Fix Done button text in narrow mode to have correct colour of text - 1564. By Andrew Hayzen
-
* Updates to theming to use theme.palette in many places and change styling of private browsing tabs
Disclaimer: only tested on desktop so far, up-to-date xenial+overlay.
The pressed state of items in the drawer menu looks very dark to me, is that intended?
The divider between tabs in the tabs bar looks plain black, it looks too dark to me, is that intended?
When hovering over a tab in the tabs bar, it looks awkward that the divider between it and the next/prev tab remains visible, is that intended?
The progress bar and the horizontal line at the bottom of the chrome are stacked, and this makes the progress bar look taller, which I find disturbing to the eye. Maybe anchor the bottom of the progress bar to the bottom of the line?
There’s no hovered and pressed states for the + button at the right of the top bar to open a new tab. Should we add them?
The reference to pad.lv/1638337 in Suggestion.qml looks like it’s the wrong bug number?