webbrowser-app

Merge lp://qastaging/~ahayzen/webbrowser-app/fix-1630211-drag-tabs-quickly-incorrect-position into lp://qastaging/webbrowser-app

  1. fix-1630211-drag-tabs-quickly-incorrect-position
  2. Merge into trunk
Proposed by Andrew Hayzen
Status: Work in progress
Proposed branch: lp://qastaging/~ahayzen/webbrowser-app/fix-1630211-drag-tabs-quickly-incorrect-position
Merge into: lp://qastaging/webbrowser-app
Prerequisite: lp://qastaging/~ahayzen/webbrowser-app/fix-1473630-close-tab-buttons-overlap
Diff against target: 98 lines (+51/-14)
3 files modified
src/app/webbrowser/TabsBar.qml (+17/-6)
src/app/webbrowser/tabs-model.cpp (+19/-3)
tests/unittests/tabs-model/tst_TabsModelTests.cpp (+15/-5)
To merge this branch: bzr merge lp://qastaging/~ahayzen/webbrowser-app/fix-1630211-drag-tabs-quickly-incorrect-position
Reviewer Review Type Date Requested Status
Andrew Hayzen (community) Disapprove
system-apps-ci-bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+307709@code.qastaging.launchpad.net

Commit message

* Change onXChanged to move to the current position of X and not just +/- 1
* Improve TabsModel::move to be able to handle gaps between the from and to

Description of the change

* Change onXChanged to move to the current position of X and not just +/- 1
* Improve TabsModel::move to be able to handle gaps between the from and to

TESTING:
- Open *many* tabs and quickly drag the first to the last position, with this branch it should always end up in the right place

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1517
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/681/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1755/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1755
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1600/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1600/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1600/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1600/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1600/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1600/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1600/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1600/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1600/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/681/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://qastaging/~ahayzen/webbrowser-app/fix-1630211-drag-tabs-quickly-incorrect-position updated
1518. By Andrew Hayzen

* Fixes for unit tests

Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1518
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/683/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1757/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1757
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1602
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1602/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1602
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1602/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1602
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1602/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1602/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1602
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1602/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1602
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1602/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1602
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1602/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1602
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1602/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1602
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1602/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/683/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://qastaging/~ahayzen/webbrowser-app/fix-1630211-drag-tabs-quickly-incorrect-position updated
1519. By Andrew Hayzen

* Merge of upstream branch lp:~ahayzen/webbrowser-app/fix-1473630-close-tab-buttons-overlap/

Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1519
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/698/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1813/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1813
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1658
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1658/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1658
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1658/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1658
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1658/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1658/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1658
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1658/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1658
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1658/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1658
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1658/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1658
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1658/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1658
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1658/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/698/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

This branch is irrelevant now as it landed in this MP https://code.launchpad.net/~ahayzen/webbrowser-app/migrate-to-tabs-component/+merge/312340.

review: Disapprove
Reply

Unmerged revisions

1519. By Andrew Hayzen

* Merge of upstream branch lp:~ahayzen/webbrowser-app/fix-1473630-close-tab-buttons-overlap/

1518. By Andrew Hayzen

* Fixes for unit tests

1517. By Andrew Hayzen

* Change onXChanged to move to the current position of X and not just +/- 1
* Improve TabsModel::move to be able to handle gaps between the from and to

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: