webbrowser-app

Merge lp://qastaging/~ahayzen/webbrowser-app/fix-depends-on-non-notifyable-prop-001 into lp://qastaging/webbrowser-app

  1. fix-depends-on-non-notifyable-prop-001
  2. Merge into trunk
Proposed by Andrew Hayzen
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 1537
Merged at revision: 1538
Proposed branch: lp://qastaging/~ahayzen/webbrowser-app/fix-depends-on-non-notifyable-prop-001
Merge into: lp://qastaging/webbrowser-app
Diff against target: 131 lines (+17/-17)
6 files modified
src/Ubuntu/Web/UbuntuWebView02.qml (+4/-4)
src/app/webbrowser/ContextMenuMobile.qml (+2/-2)
src/app/webbrowser/ContextMenuWide.qml (+4/-4)
src/app/webcontainer/ContextMenuMobile.qml (+2/-2)
src/app/webcontainer/ContextMenuWide.qml (+4/-4)
tests/unittests/qml/tst_UbuntuWebView02.qml (+1/-1)
To merge this branch: bzr merge lp://qastaging/~ahayzen/webbrowser-app/fix-depends-on-non-notifyable-prop-001
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Olivier Tilloy Approve
Review via email: mp+306087@code.qastaging.launchpad.net

Commit message

* Change use of ActionList.actions to ActionList.children and use modelData in Repeaters

Description of the change

* Change use of ActionList.actions to ActionList.children and use modelData in Repeaters

This fixes errors in the console such as "depends on non-NOTIFYable properties: ActionList::actions".

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1536
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/642/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1546/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1546
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1394/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1394/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1394/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1394/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1394/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1394/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1394/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1394/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1394/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/642/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~ahayzen/webbrowser-app/fix-depends-on-non-notifyable-prop-001 updated
1537. By Andrew Hayzen

* Fix for failing unit test

Revision history for this message
Olivier Tilloy (osomon) wrote :

LGTM.

review: Approve
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1537
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/643/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/1550
    UNSTABLE: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=default/360
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1550
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1398
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1398/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1398
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1398/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1398
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1398/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1398
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1398/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1398
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1398/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1398
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1398/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1398
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1398/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1398
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1398/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1398
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1398/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/643/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: