simplestreams

Merge lp://qastaging/~ajkavanagh/simplestreams/keystone-v3-support into lp://qastaging/simplestreams

  1. keystone-v3-support
  2. Merge into trunk
Proposed by Alex Kavanagh
Status: Merged
Merged at revision: 450
Proposed branch: lp://qastaging/~ajkavanagh/simplestreams/keystone-v3-support
Merge into: lp://qastaging/simplestreams
Diff against target: 71 lines (+39/-6)
1 file modified
simplestreams/openstack.py (+39/-6)
To merge this branch: bzr merge lp://qastaging/~ajkavanagh/simplestreams/keystone-v3-support
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
David Ames (community) Needs Fixing
simplestreams-dev Pending
Review via email: mp+325566@code.qastaging.launchpad.net

Description of the change

Add support for the Keystone v3 API

simplestreams.openstack is hardcoded for Keystone API v2 client. This change adds
support for Keystone API v3. The version of the API requested is derived from
auth_url and if that fails it falls back to v2.

(This changed borrowed from, with a few changes, from the gnuoy branch that wasn't
merged due to flake errors.)

Closes-Bug: Bug #1624306

To post a comment you must log in.
Revision history for this message
David Ames (thedac) wrote :

This is currently missing a few bits.

Specifically the check for tenant_id or tenant_name breaks.

More details to come, but please do not merge this yet.

review: Needs Fixing
Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

We may need to chat this through some more.

Revision history for this message
David Ames (thedac) wrote :

Alex,

This has been superseded by https://code.launchpad.net/~thedac/simplestreams/keystone-v3-support/+merge/325781

That MP includes this one with a couple of extra changes. Please add your review there.

Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:450
https://jenkins.ubuntu.com/server/job/simplestreams-ci/38/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/simplestreams-ci/nodes=metal-amd64/38
    SUCCESS: https://jenkins.ubuntu.com/server/job/simplestreams-ci/nodes=metal-arm64/38
    SUCCESS: https://jenkins.ubuntu.com/server/job/simplestreams-ci/nodes=metal-ppc64el/38
    SUCCESS: https://jenkins.ubuntu.com/server/job/simplestreams-ci/nodes=metal-s390x/38
    SUCCESS: https://jenkins.ubuntu.com/server/job/simplestreams-ci/nodes=vm-i386/38

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/simplestreams-ci/38/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches