Percona Server moved to https://jira.percona.com/projects/PS

Merge lp://qastaging/~akopytov/percona-server/BT27273-file-format-detection-in-innochecksum into lp://qastaging/percona-server/5.5

BT27273-file-format-detection-in-innochecksum
Merge into 5.5

Proposed by Alexey Kopytov on 2012-11-22

Status:	Merged
Approved by:	Laurynas Biveinis on 2012-11-27
Approved revision:	no longer in the source branch.
Merged at revision:	358
Proposed branch:	lp://qastaging/~akopytov/percona-server/BT27273-file-format-detection-in-innochecksum
Merge into:	lp://qastaging/percona-server/5.5
Diff against target:	160 lines (+92/-3) 1 file modified Percona-Server/extra/innochecksum.c (+92/-3)
To merge this branch:	bzr merge lp://qastaging/~akopytov/percona-server/BT27273-file-format-detection-in-innochecksum
Related bugs:	Link a bug report
Related blueprints:	Extend innochecksum to display file format in InnoDB files (Undefined)

Reviewer	Review Type	Date Requested	Status
Laurynas Biveinis (community)		2012-11-22	Approve on 2012-11-27
Review via email: mp+135669@code.qastaging.launchpad.net

Description of the change

Implementation of https://blueprints.launchpad.net/percona-server/+spec/file-format-detection-in-innochecksum.

Revision history for this message

Alexey Kopytov (akopytov) wrote on 2012-11-22:

No Jenkins build, as the test suite has no tests for innochecksum anyway.

Revision history for this message

Laurynas Biveinis (laurynas-biveinis) wrote on 2012-11-27:

Looks good.

Some comments if we ever revisit this for some reason (might be converted to wishlist bugs)
- there is no reason not to test this feature at least minimally. The testcase seems to be straightforward enough as long as we don't care about pre-5.1.7 format.
- mach_read_from_2 should be "static inline"
- display_format_info arg should be const.

review: Approve