Percona Server moved to https://jira.percona.com/projects/PS

Merge lp://qastaging/~akopytov/percona-server/bug858945-5.1 into lp://qastaging/percona-server/5.1

Proposed by Alexey Kopytov on 2011-09-29

Status:

Merged

Merge reported by:

Merged at revision:

not available

Proposed branch:

Merge into:

Diff against target:

1 file modified

patches/innodb_expand_fast_index_creation.patch (+198/-81)

To merge this branch:

bzr merge lp://qastaging/~akopytov/percona-server/bug858945-5.1

Undecided

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Laurynas Biveinis (community)	2011-09-29	Approve on 2011-10-05
Oleg Tsarev (community)	2011-09-29	Approve on 2011-09-29
Review via email: mp+77544@code.qastaging.launchpad.net

Revision history for this message

Alexey Kopytov (akopytov) wrote on 2011-09-29:

Revision history for this message

Oleg Tsarev (tsarev) wrote on 2011-09-29:

LGTM

review: Approve

Revision history for this message

Laurynas Biveinis (laurynas-biveinis) wrote on 2011-10-05:

LGTM with
diff line 329: s/InnoDB/the InnoDB
line 330: s/fast/the fast

Enable/disable improvements to the InnoDB fast index creation functionality.
Has no effect when the fast index creation is disabled with the

review: Approve

Revision history for this message

Alexey Kopytov (akopytov) wrote on 2011-10-05:

Agree on line 329.
Disagree on line 330: creation is an uncountable noun in this context. So it should used without an article.

Compare, for example, http://www.google.com/search?q=site%3Adev.mysql.com+"the+fast+index+creation" with http://www.google.com/search?q=site%3Adev.mysql.com+"fast+index+creation". The article is only used with the word "creation" is followed by "feature" which is a countable noun, so using an article is correct.