Merge lp://qastaging/~akopytov/percona-xtrabackup/support-remote-tablespaces-2.0 into lp://qastaging/percona-xtrabackup/2.0

Proposed by Alexey Kopytov
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 545
Proposed branch: lp://qastaging/~akopytov/percona-xtrabackup/support-remote-tablespaces-2.0
Merge into: lp://qastaging/percona-xtrabackup/2.0
Prerequisite: lp://qastaging/~akopytov/percona-xtrabackup/bug1169169-2.0
Diff against target: 1849 lines (+769/-195)
23 files modified
innobackupex (+68/-14)
patches/innodb56.patch (+293/-38)
src/xtrabackup.cc (+147/-51)
test/inc/common.sh (+47/-27)
test/inc/ib_part.sh (+5/-5)
test/t/bug1062684.sh (+11/-4)
test/t/bug483827.sh (+1/-4)
test/t/bug606981.sh (+9/-5)
test/t/bug740489.sh (+22/-14)
test/t/bug759225.sh (+6/-4)
test/t/bug870119.sh (+6/-3)
test/t/bug891496.sh (+6/-8)
test/t/bug976945.sh (+4/-2)
test/t/bug977101.sh (+3/-4)
test/t/ib_doublewrite.sh (+6/-3)
test/t/ib_part_include.sh (+2/-2)
test/t/ib_part_tf_innodb.sh (+2/-2)
test/t/ib_slave_info.sh (+2/-2)
test/t/remote_tablespaces.sh (+53/-0)
test/t/undo_tablespaces.sh (+75/-0)
test/t/xb_basic.sh (+0/-1)
test/t/xb_version.sh (+0/-1)
test/testrun.sh (+1/-1)
To merge this branch: bzr merge lp://qastaging/~akopytov/percona-xtrabackup/support-remote-tablespaces-2.0
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+160315@code.qastaging.launchpad.net

Description of the change

    Implementation of
    https://blueprints.launchpad.net/percona-xtrabackup/+spec/support-remote-tablespaces

    On backup, copy both .isl and .ibd files for remote tablespaces. Remote
    .ibd files are copied to the corresponding database directory under the
    backup root directory as if there were local tablespaces.

    On prepare, ignore .isl files and possible inconsistencies of tablespace
    locations with the data dictionary, i.e. handle all tablespaces as local
    ones.

    On restore, innobackupex checks if there's an .isl file corresponding to
    the .ibd file being copied. If so, it uses the original remote
    tablespace location instead of the default location under the data
    directory.

    Changes in the ib_part_* tests are necessery to support 2 additional SYS_*
    tables in the data dictionary (SYS_TABLESPACES and SYS_DATAFILES). To
    avoid dependency on the number of SYS_* tables, they are now excluded
    from the 'xtrabackup --stats' output, i.e. only user tables are counted.

http://jenkins.percona.com/view/XtraBackup/job/percona-xtrabackup-2.0-param/412/

To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) wrote :
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

I assume rev 534 is not a part of this MP, and only reviewed rev 535.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches