Merge lp://qastaging/~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456 into lp://qastaging/~hr-core-editors/hr-timesheet/7.0

Proposed by Alexis de Lattre
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 64
Merged at revision: 65
Proposed branch: lp://qastaging/~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456
Merge into: lp://qastaging/~hr-core-editors/hr-timesheet/7.0
Diff against target: 51 lines (+12/-6)
2 files modified
timesheet_task/project_task.py (+10/-4)
timesheet_task/project_task_view.xml (+2/-2)
To merge this branch: bzr merge lp://qastaging/~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no test Approve
Stéphane Bidoul (Acsone) (community) code review, no test Approve
Pedro Manuel Baeza code review Approve
Alexandre Fayolle - camptocamp code review, no test Approve
Review via email: mp+218364@code.qastaging.launchpad.net

Description of the change

I have fixed the bug https://bugs.launchpad.net/hr-timesheet/+bug/1316456 in this merge proposal. Please refer to the bug report to get a complete bug description with the scenario to reproduce it.

To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM

review: Approve (code review, no test)
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM.

Regards.

review: Approve (code review)
Revision history for this message
Stéphane Bidoul (Acsone) (sbi) wrote :

Makes sense.

review: Approve (code review, no test)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM thanks for the fix

review: Approve (code review, no test)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches