Odoo Addons (MOVED TO GITHUB)

Merge lp://qastaging/~akretion-team/openobject-addons/trunk-add-tax-rounding-option into lp://qastaging/openobject-addons

trunk-add-tax-rounding-option
Merge into trunk

Proposed by Alexis de Lattre on 2012-07-07

Status:

Merged

Merged at revision:

7018

Proposed branch:

lp://qastaging/~akretion-team/openobject-addons/trunk-add-tax-rounding-option

Merge into:

lp://qastaging/openobject-addons

Diff against target:

172 lines (+40/-11)

5 files modified

account/account.py (+25/-11)
account/company.py (+6/-0)
account/company_view.xml (+1/-0)
account/res_config.py (+7/-0)
account/res_config_view.xml (+1/-0)

To merge this branch:

bzr merge lp://qastaging/~akretion-team/openobject-addons/trunk-add-tax-rounding-option

Wishlist

Fix Released

Link a bug report

Reviewer	Date Requested	Status
qdp (OpenERP)		Pending
OpenERP Core Team	2012-07-07	Pending
Review via email: mp+113833@code.qastaging.launchpad.net

Description of the change

This merge proposal replaces this first merge proposal :

https://code.launchpad.net/~akretion-team/openobject-addons/trunk-addons-tax-calculation-decimal-precision/+merge/103579

It implements the suggestion that Fabien wrote in the comments of the first merge proposal to have a simple option "round per line"/"round globally".

Revision history for this message

Lorenzo Battistini (elbati) wrote on 2012-07-10:

Hello Alexis, please consider adding the YAML tests I already did for my patch

tests: http://bazaar.launchpad.net/~openerp-community/openobject-addons/fix-account-trunk-tax-computation-method/view/head:/account/test/tax_computation.yml
patch: https://code.launchpad.net/~openerp-community/openobject-addons/fix-account-trunk-tax-computation-method/+merge/104945

Revision history for this message

Alexis de Lattre (alexis-via) wrote on 2012-07-11:

@Lorenzo

I am not (yet) familiar with YAML, so I can't review your proposal, sorry.

Revision history for this message

Lorenzo Battistini (elbati) wrote on 2012-07-12:

On 07/11/2012 10:55 PM, Alexis de Lattre wrote:
> @Lorenzo
>
> I am not (yet) familiar with YAML, so I can't review your proposal, sorry.

Hello Alexis, I just adapted my tests to your implementation and it
passed them.
So, well done :-)

I propose to merge them
<https://code.launchpad.net/%7Eelbati/openobject-addons/add-yaml-tests-for-tax-computation/+merge/114679>
into the account, sale and purchase modules.

Just one remark: as correctly pointed by Ferdinand
<https://lists.launchpad.net/openerp-expert-accounting/msg01728.html>,
there should be the possibility to set the 'Tax calculation rounding
method' at partner and document level. This is because a company could
receive some supplier invoices computed by 'Round per line' and some
others by 'Round globally'. So, user should be able to change the
behaviour according to the case.

Regards and thanks for your work.

--
Lorenzo Battistini
http://planet.domsense.com/en/author/elbati/