Merge lp://qastaging/~akretion-team/project-service/add-project-action-item into lp://qastaging/~project-core-editors/project-service/trunk
Status: | Needs review |
---|---|
Proposed branch: | lp://qastaging/~akretion-team/project-service/add-project-action-item |
Merge into: | lp://qastaging/~project-core-editors/project-service/trunk |
Diff against target: |
1296 lines (+1230/-0) 11 files modified
project_action_item/__init__.py (+24/-0) project_action_item/__openerp__.py (+54/-0) project_action_item/i18n/fr.po (+277/-0) project_action_item/i18n/project_action_item.pot (+277/-0) project_action_item/project.py (+179/-0) project_action_item/project_demo.xml (+64/-0) project_action_item/project_view.xml (+151/-0) project_action_item/security/ir.model.access.csv (+2/-0) project_action_item/wizard/__init__.py (+23/-0) project_action_item/wizard/update_action_generate_timesheet.py (+137/-0) project_action_item/wizard/update_action_generate_timesheet_view.xml (+42/-0) |
To merge this branch: | bzr merge lp://qastaging/~akretion-team/project-service/add-project-action-item |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lorenzo Battistini (community) | Abstain | ||
Raphaël Valyi - http://www.akretion.com | Approve | ||
Daniel Reis | Needs Fixing | ||
Review via email: mp+216224@code.qastaging.launchpad.net |
Description of the change
This merge proposal adds the module "project_
Extract from the module description :
This module adds action items on project tasks. When a user has completed the action item of a task, he can click on a button "Done with Timesheet" that starts a wizard ; this wizard will mark the action item as done and will create a timesheet line.
The idea behind this module is the following : on a task, we have the timesheet lines that give you the history of the actions made for that task... but we don't have anything to store the actions that must be carried out for that action (apart from the text field "description"). So, with this module : on a task, the timesheet lines (object hr.analytic.
Unmerged revisions
- 40. By Alexis de Lattre
-
[Usability] Larger display for the action description.
- 39. By Alexis de Lattre
-
[Usability] implement some of the remarks of Daniel Reis :
- one menu entry instead of 2
- display "Worked Hours" in Tree view and re-order cols - 38. By Alexis de Lattre
-
[Usability] Put action items above timesheets, in the same tab
- 37. By Alexis de Lattre
-
Add icon on button in tree view
Add related field projet_id
Now that we have both "todo" and "progress", the state field should always be visible. - 36. By Alexis de Lattre
-
Continue to implement the remarks of Daniel :
- add computed field timesheet_hours on project.action.item
- replace the native field 'planned_hours' on task by a computed field (sum of action items)
Update some strings and field names (Quantity -> Hours)
Flake8 validation - 35. By Alexis de Lattre
-
Implement some suggestions of Daniel Reis :
- explain where to find the module hr_timesheet_task in module description
- add state "In Progress" and adapt the wizard and buttons
- add field "to_invoice" on action item, that will be copied to the timesheet
- change "Done with timesheet" to "Done" in the tree view. - 34. By Alexis de Lattre
-
Add module project_
action_ item.
Very nice feature Alexis.
I tried it out, and I have some comments:
* I would be nice to inform where the lp branch "hr_timesheet_task" can be found, at least until openerpapps.info rules the world.
* The "Done with timesheet" is not a real button. It took me some time to realize it's test was clickable.
* IMO "Done with timesheet" is a confusing label. I would prefer "Log on Timesheet" or the even simpler "Done".
* Actions should heave a sequence field, and be manually reordered in the Task Actions tab.
* If you have the "Manage time estimation on tasks" feature activated, the Task's estimated time should be computed as the total Actions estimated time (in the demo data, the Tasks estimated time is 22h and the Action estimated time is 70h).
* When an Action is Done, you can't see the actual time spent.
* At the time you are creating the Action list, you should be able to set if you expect it to be billable (or expected Invoicing Ratio).
* You can't log time on an Action without completing it. The demo action "Develop final version" is 42h long, will surely span more than a week, and you will surely won't be able to wait until it's completed to log the time spent.
I suggest the wizard to let you log time on timesheet for an action, but keep it as not done / in progress.
Just some food for thought; it may be a bad idea, but:
What if instead of "Actions" we had "Child Tasks"? If that implementation strategy doesn't bring a lot of difficulties, It would open up a lot of interesting use cases ...