Merge lp://qastaging/~akretion-team/project-service/project-service-base-sale-project into lp://qastaging/~project-core-editors/project-service/trunk
Proposed by
Sébastien BEAU - http://www.akretion.com
Status: | Merged |
---|---|
Merged at revision: | 32 |
Proposed branch: | lp://qastaging/~akretion-team/project-service/project-service-base-sale-project |
Merge into: | lp://qastaging/~project-core-editors/project-service/trunk |
Diff against target: |
272 lines (+241/-0) 6 files modified
sale_project_base/__init__.py (+26/-0) sale_project_base/__openerp__.py (+43/-0) sale_project_base/i18n/sale_project_base.po (+38/-0) sale_project_base/project.py (+37/-0) sale_project_base/sale.py (+69/-0) sale_project_base/sale_view.xml (+28/-0) |
To merge this branch: | bzr merge lp://qastaging/~akretion-team/project-service/project-service-base-sale-project |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Reis | lgtm, no test | Approve | |
Pedro Manuel Baeza | code review | Approve | |
Review via email:
|
Description of the change
Hi,
We are cleanning and improving our OpenERP, so we plan to contribute everything here !
Let's start with some basic module
Here it's just a base module in order to link correctly a project and a sale order and also to create a project from a sale order.
No big thing, it's an base module that can be usefull in many case
Thanks for your review
To post a comment you must log in.
Hi, Sébastien, some remarks from a quick scan:
- Why do you need to declare a new field 'true_project_id' instead of using existing 'project_id'?
- You can put auto_install to True so that if sale and project are installed, this module is automatically installed.
- A similar module that glues sale and stock is called sale_stock. Maybe you can call yours sale_project.
Thanks for the contribution.
Regards.