Merge lp://qastaging/~alan-griffiths/compiz-core/Law-of-Demeter-applied-to-CompScreen into lp://qastaging/compiz-core/0.9.8
Proposed by
Alan Griffiths
| Status: | Merged |
|---|---|
| Merged at revision: | 3133 |
| Proposed branch: | lp://qastaging/~alan-griffiths/compiz-core/Law-of-Demeter-applied-to-CompScreen |
| Merge into: | lp://qastaging/compiz-core/0.9.8 |
| Diff against target: |
950 lines (+233/-120) 8 files modified
include/core/abiversion.h (+1/-1) include/core/screen.h (+35/-6) scripts/run-with-xvfb.sh (+9/-10) src/event.cpp (+13/-13) src/modifierhandler.cpp (+1/-1) src/privatescreen.h (+2/-19) src/screen.cpp (+119/-17) src/window.cpp (+53/-53) |
| To merge this branch: | bzr merge lp://qastaging/~alan-griffiths/compiz-core/Law-of-Demeter-applied-to-CompScreen |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sam Spilsbury | Approve | ||
|
Review via email:
|
|||
Description of the change
Eliminate friend declarations from CompScreen interface. That removes loads of "screen->priv->..." calls from other classes.
This adds a number of functions to the public interface, some of which ought to be used with care. There are ways limit this access, but that consideration also applies to many existing functions.
A future exercise should separate out the "internal use" functions and make it harder to invoke them from non-core code. (But this diff is enough to grok already.)
To post a comment you must log in.
Revision history for this message
| Sam Spilsbury (smspillaz) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
