Compiz Core

Merge lp://qastaging/~alan-griffiths/compiz-core/bug.968985 into lp://qastaging/compiz-core

bug.968985
Merge into 0.9.7

Proposed by Alan Griffiths on 2012-03-30

Status:	Superseded
Proposed branch:	lp://qastaging/~alan-griffiths/compiz-core/bug.968985
Merge into:	lp://qastaging/compiz-core
Diff against target:	188 lines (+107/-23) 5 files modified NEWS (+1/-0) src/plugin.cpp (+15/-21) src/plugin/tests/CMakeLists.txt (+19/-0) src/plugin/tests/test-loader.cpp (+72/-0) src/plugin/tests/test-plugin.cpp (+0/-2)
To merge this branch:	bzr merge lp://qastaging/~alan-griffiths/compiz-core/bug.968985
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Daniel van Vugt		2012-03-30	Needs Fixing on 2012-03-30
Review via email: mp+100086@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2012-03-30.

Description of the change

Fix memory leak in dlloaderListPlugins (lp:968985)

lp://qastaging/~alan-griffiths/compiz-core/bug.968985 updated on 2012-03-30

3082. By Alan Griffiths on 2012-03-30: Memory leak in dlloaderListPlugins

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2012-03-30:

Crashes on line 268

review: Needs Fixing

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2012-03-30:

==30573== Conditional jump or move depends on uninitialised value(s)
==30573== at 0x4C28293: free (vg_replace_malloc.c:366)
==30573== by 0x4EA2DB1: dlloaderListPlugins(char const*) (plugin.cpp:268)
==30573== by 0x4EA338A: CompPlugin::availablePlugins() (plugin.cpp:545)
==30573== by 0x4E74BDF: compiz::private_screen::PluginManager::mergedPluginList() (screen.cpp:899)
==30573== by 0x4E754F9: compiz::private_screen::PluginManager::updatePlugins() (screen.cpp:959)
==30573== by 0x40358F: CompManager::init() (main.cpp:173)
==30573== by 0x402988: main (main.cpp:234)
==30573==
==30573== Invalid free() / delete / delete[]
==30573== at 0x4C282E0: free (vg_replace_malloc.c:366)
==30573== by 0x4EA2DB1: dlloaderListPlugins(char const*) (plugin.cpp:268)
==30573== by 0x4EA338A: CompPlugin::availablePlugins() (plugin.cpp:545)
==30573== by 0x4E74BDF: compiz::private_screen::PluginManager::mergedPluginList() (screen.cpp:899)
==30573== by 0x4E754F9: compiz::private_screen::PluginManager::updatePlugins() (screen.cpp:959)
==30573== by 0x40358F: CompManager::init() (main.cpp:173)
==30573== by 0x402988: main (main.cpp:234)
==30573== Address 0x1d is not stack'd, malloc'd or (recently) free'd