Merge lp://qastaging/~alan-griffiths/compiz-core/more-updatePlugins-testing into lp://qastaging/compiz-core

Proposed by Alan Griffiths
Status: Merged
Approved by: Alan Griffiths
Approved revision: 3073
Merge reported by: Alan Griffiths
Merged at revision: not available
Proposed branch: lp://qastaging/~alan-griffiths/compiz-core/more-updatePlugins-testing
Merge into: lp://qastaging/compiz-core
Diff against target: 230 lines (+146/-33)
1 file modified
src/privatescreen/tests/test-privatescreen.cpp (+146/-33)
To merge this branch: bzr merge lp://qastaging/~alan-griffiths/compiz-core/more-updatePlugins-testing
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Sam Spilsbury Approve
Review via email: mp+99507@code.qastaging.launchpad.net

Description of the change

Some additional testing of updatePlugins inspired by #963264

To post a comment you must log in.
3071. By Alan Griffiths

A bit of explanation about the test

3072. By Alan Griffiths

More explicit setting and checking of expectations

3073. By Alan Griffiths

Decouple EventManager test from Display setup

Revision history for this message
Sam Spilsbury (smspillaz) :
review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Replaced by: https://code.launchpad.net/~vanvugt/compiz-core/fix-startup-plugins/+merge/99886
Which has no such regressions. And is smaller, simpler.

review: Disapprove
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Argh! Sorry, wrong proposal.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches