Merge lp://qastaging/~alan-griffiths/compiz-core/private_screen-EventManager1 into lp://qastaging/compiz-core

Looks OK, works OK.

Though think it would be more elegant and better for maintenance to wrap functions in a single:
    namespace compiz::private_screen { ... }
instead of prefixing them with "cps::".

Or rather wrap them in:
    namespace compiz { namespace private_screen {
    ...
    }}

I also think everything in compiz_core should just be in a single namespace "compiz" unless it's built into a separate static lib.

On 13/03/12 03:41, Daniel van Vugt wrote:
> Or rather wrap them in: namespace compiz { namespace private_screen
> { ... }}

This is something on which reasonable people may differ. I prefer the
"cps::" approach because of the following use case:

// header
namespace example {
void center();
}

// implementation-v1
void example::centre() {}
// Compiler error

// implementation-v2
namespace example {
void example::centre() {}
// No compiler error - just not what's intended
}

>
> I also think everything in compiz_core should just be in a single
> namespace "compiz" unless it's built into a separate static lib.

I think the /public/ interface should be in namespace compiz, and that
the implementation details should be in a nested namespace
compiz::detail (say). But that would introduce yet another style.

--
Alan Griffiths +44 (0)798 9938 758
Octopull Ltd http://www.octopull.co.uk/