Merge lp://qastaging/~alan-griffiths/compiz-core/stop-dumping-windows-in-first-workspace into lp://qastaging/compiz-core
Proposed by
Alan Griffiths
Status: | Merged |
---|---|
Merged at revision: | 3092 |
Proposed branch: | lp://qastaging/~alan-griffiths/compiz-core/stop-dumping-windows-in-first-workspace |
Merge into: | lp://qastaging/compiz-core |
Diff against target: |
19 lines (+3/-1) 1 file modified
src/window.cpp (+3/-1) |
To merge this branch: | bzr merge lp://qastaging/~alan-griffiths/compiz-core/stop-dumping-windows-in-first-workspace |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Approve | ||
Sam Spilsbury | Approve | ||
Review via email:
|
Description of the change
Avoid dumping all the windows into first workspace when closing.
Reverts to correct logic used before r2838.
To post a comment you must log in.
From discussion with Sam:
"CompWindowNoti fyUnreparent would call through to DecorWindow: :windowNotify and then that would call reconfigureXWindow, which would then attempt to configure the destroyed frame and wrapper windows and move the client to 0,0 in its own parent window, which at this point, would be the root window (so the client moves to 0,0). I know this because its exactly the same problem I fixed last cycle :P
"The fix is to move the assignments (and the queue clear) to None to before that call. That will cause reconfigureXWindow to treat the window as an unreparented window, eg, correctly."