Merge lp://qastaging/~alan-griffiths/mir/discussion-migrate-demo-shell into lp://qastaging/mir
Proposed by
Alan Griffiths
Status: | Rejected |
---|---|
Rejected by: | Alan Griffiths |
Proposed branch: | lp://qastaging/~alan-griffiths/mir/discussion-migrate-demo-shell |
Merge into: | lp://qastaging/mir |
Prerequisite: | lp://qastaging/~alan-griffiths/mir/migrate-render_surfaces |
Diff against target: |
559 lines (+97/-244) 15 files modified
CMakeLists.txt (+0/-1) examples/CMakeLists.txt (+2/-0) examples/demo-shell/CMakeLists.txt (+4/-1) examples/demo-shell/demo_shell.cpp (+53/-90) include/server/mir/default_server_configuration.h (+2/-1) include/server/mir/server.h (+26/-3) playground/CMakeLists.txt (+0/-16) playground/README (+0/-6) playground/server_configuration.cpp (+0/-72) playground/server_configuration.h (+0/-50) server-ABI-sha1sums (+2/-2) src/server/server.cpp (+3/-0) src/server/symbols.map (+3/-0) tests/unit-tests/examples/test_demo_compositor.cpp (+1/-1) tests/unit-tests/examples/test_demo_renderer.cpp (+1/-1) |
To merge this branch: | bzr merge lp://qastaging/~alan-griffiths/mir/discussion-migrate-demo-shell |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Needs Fixing | ||
Alan Griffiths | Needs Information | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Kevin DuBois (community) | Disapprove | ||
Review via email:
|
Commit message
examples: update the demo-shell example to use the mir::Server API
Description of the change
examples: update the demo-shell example to use the mir::Server API
This involves exposing stuff that had been "privatized" and this might not be the best way to expose the functionality needed. Hence I'd like some discussion about whether this is justified.
To post a comment you must log in.
Unmerged revisions
- 2140. By Alan Griffiths
- 2139. By Alan Griffiths
-
merge lp:mir
- 2138. By Alan Griffiths
- 2137. By Alan Griffiths
-
Move demo-shell to examples
- 2136. By Alan Griffiths
-
Publish headers referenced by demo shell
- 2135. By Alan Griffiths
-
Tidy up demo code
- 2134. By Alan Griffiths
-
Delete dead code
- 2133. By Alan Griffiths
-
BFI migration of demo shell away from legacy API
- 2132. By Alan Griffiths
Our downstreams have been able to get along without our utility classes ( suggestion to others as to how they should use GLES.
gl_program, gl_texture, gl_primitive, gl_renderer, etc) to this point, and re-exposing them exposes a lot of ABI that has been hidden and is not used. These classes are more utility classes of the way we've used GLES internally than a recommendation/
I think its possible to transition the demo shell from playground to examples with a bit of more in-depth "surgery" to have it target reimplementing our already-exposed /interfaces/ instead of overriding different components of utility classes.