Mir

Merge lp://qastaging/~alan-griffiths/mir/does-jenkins-like-MultiThreadedCompositor-refactoring into lp://qastaging/mir

  1. does-jenkins-like-MultiThreadedCompositor-refactoring
  2. Merge into development-branch
Proposed by Alan Griffiths
Status: Rejected
Rejected by: Alan Griffiths
Proposed branch: lp://qastaging/~alan-griffiths/mir/does-jenkins-like-MultiThreadedCompositor-refactoring
Merge into: lp://qastaging/mir
Diff against target: 257 lines (+82/-81)
2 files modified
src/server/compositor/multi_threaded_compositor.cpp (+80/-79)
tests/unit-tests/compositor/test_multi_threaded_compositor.cpp (+2/-2)
To merge this branch: bzr merge lp://qastaging/~alan-griffiths/mir/does-jenkins-like-MultiThreadedCompositor-refactoring
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Mir CI Bot continuous-integration Approve
Mir development team Pending
Review via email: mp+284079@code.qastaging.launchpad.net

Commit message

compositor: clearer logic for MultiThreadedCompositor::start()/stop()

Description of the change

compositor: clearer logic for MultiThreadedCompositor::start()/stop()

This should be a pure refactoring extracted from lp:~alan-griffiths/mir/better-error-reporting-in-MultiThreadedCompositor-start (as I've not identified the problem causing CI failures there).

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:3274
https://mir-jenkins.ubuntu.com/job/mir-ci/166/
Executed test runs:
    None: https://mir-jenkins.ubuntu.com/job/generic-update-mp/166/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/166/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3274
http://jenkins.qa.ubuntu.com/job/mir-ci/6135/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5703
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4610
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5659
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-xenial-touch/340
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/459
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/459/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/459
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/459/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5656
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5656/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/8088
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27072
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/336
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/336/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-xenial-touch/192
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27074

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6135/rebuild

review: Approve (continuous-integration)
lp://qastaging/~alan-griffiths/mir/does-jenkins-like-MultiThreadedCompositor-refactoring updated
3275. By Alan Griffiths

  Report errors starting compositor threads by propagating exception from start()

3276. By Alan Griffiths

Experiment to diagnose Jenkins failures

Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:3276
https://mir-jenkins.ubuntu.com/job/mir-ci/168/
Executed test runs:
    None: https://mir-jenkins.ubuntu.com/job/generic-update-mp/168/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/168/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3276
http://jenkins.qa.ubuntu.com/job/mir-ci/6138/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5706
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4613
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5662
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-xenial-touch/341
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/462
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/462/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/462
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/462/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5659
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5659/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/8089
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27077
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/337
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/337/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-xenial-touch/193
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27088

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/6138/rebuild

review: Approve (continuous-integration)

Unmerged revisions

3276. By Alan Griffiths

Experiment to diagnose Jenkins failures

3275. By Alan Griffiths

  Report errors starting compositor threads by propagating exception from start()

3274. By Alan Griffiths

  Don't mix level of abstraction within a function

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches