Merge lp://qastaging/~alan-griffiths/mir/even-NullWindowManager-configures-surface into lp://qastaging/mir
Proposed by
Alan Griffiths
Status: | Rejected |
---|---|
Rejected by: | Alan Griffiths |
Proposed branch: | lp://qastaging/~alan-griffiths/mir/even-NullWindowManager-configures-surface |
Merge into: | lp://qastaging/mir |
Diff against target: |
264 lines (+69/-68) 5 files modified
include/server/mir/shell/skeleton_window_manager.h (+4/-4) src/server/shell/CMakeLists.txt (+3/-3) src/server/shell/abstract_shell.cpp (+1/-1) src/server/shell/skeleton_window_manager.cpp (+39/-38) src/server/symbols.map (+22/-22) |
To merge this branch: | bzr merge lp://qastaging/~alan-griffiths/mir/even-NullWindowManager-configures-surface |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexandros Frantzis (community) | Needs Information | ||
Daniel van Vugt | Needs Fixing | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Robert Carr (community) | Approve | ||
Review via email:
|
Commit message
shell: add surface-
Description of the change
shell: add surface-
back in -c2391 AbstractShell stopped configuring the surface to give the window manager more control. But that silently changed NullWindowManager from allowing everything to preventing everything. This reverts that unintended effect.
Yes, as downstreams can NullWindowManager there ought to be some tests about. I've added it to my list but wanted this fix to have a chance to land early.
To post a comment you must log in.
Unmerged revisions
- 2427. By Alan Griffiths
-
merge lp:mir
- 2426. By Alan Griffiths
-
merge lp:mir
- 2425. By Alan Griffiths
-
NullWindowManager => SkeletonWindowM
anager - 2424. By Alan Griffiths
-
NullWindowManager should configure surface
Raises some questions about the name ;) but ok.